Docs: HASH_SALT in fly.io example is not documented in list of environment variables

[gridsystem]

Describe the Bug

The fly.io example in the documentation instructs the user to set an environment variable, HASH_SALT.

fly secrets set HASH_SALT="", using whatever string you want to salt the hash.

This environment variable isn't in the documentation's list of environment variables. There is a similar variable in that list, APP_SECRET.

APP_SECRET = A random string used to generate unique values.

Is the fly.io example using a deprecated variable which needs changing to APP_SECRET? Does HASH_SALT need to be added to the list of environment variables?

Database

PostgreSQL

Relevant log output

No response

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

[SmartPhoneLover]

+1

[mikecao]

HASH_SALT was used in v1. You should be using APP_SECRET now.

[SmartPhoneLover]

Thanks for the info mikecao. So, I would suggest to include the old variable in the documentation page, but telling the used that it's now deprecated for v2.

[gridsystem]

HASH_SALT was used in v1. You should be using APP_SECRET now.

Is anything else in the fly.io guide outdated?

[paulrudy]

@mikecao I created the documentation page for running on fly. I wasn't aware that with v2, we should be using APP_SECRET. For already running instances of Umami v2, can APP_SECRET be safely added and HASH_SALT removed, without disrupting anything?

[mikecao]

@paulrudy Yes

[paulrudy]

Ok, I created a PR to reflect the change, along with a couple of other PRs for that doc—a typo, and removing HOSTNAME env variable as it's no longer needed since Umami version 2.7.0.

[mikecao]

PR merged.