kge icon indicating copy to clipboard operation
kge copied to clipboard

Added a checking to see whether any values are NaN in the scoring.

Open Filco306 opened this issue 4 years ago • 2 comments

Regarding issue #220 - by adding a check if there are any NaN values, a ValueError will be thrown if a nan-value is found.

If I am to be self-critical, there is a risk that the speed might be lower, but I still think it is necessary in order to ensure a correct evaluation.

Filco306 avatar Sep 26 '21 12:09 Filco306

I agree that it's good to have a check for NaN values. It should be in the evaluation code, not the model code, however.

rgemulla avatar Sep 27 '21 07:09 rgemulla

Good point. I will make changes accordingly!

Filco306 avatar Oct 04 '21 09:10 Filco306