UnityPlugin icon indicating copy to clipboard operation
UnityPlugin copied to clipboard

Add a pinch to paint example scene to the preview package

Open JuliaRonnebergerUL opened this issue 2 years ago • 1 comments

Summary

Adding a minimal version of paint to the preview package to show off the pinch detector, the pinch cursor and paint ribbons

Contributor Tasks

These tasks are for the merge request creator to tick off when creating a merge request.

  • [ ] Pair review with a member of the QA team.
  • [x] Add any release testing considerations to the MR for the next release.
  • [x] Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.
  • [x] If this MR closes a Jira issue, make sure the fix version on the JIRA issue is set to the correct one.

Reviewer Tasks

Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.

Use emojis in review threads to communicate intent and help contributors.

  • [ ] Code reviewed.
  • [x] Non-code assets e.g. Unity assets/scenes reviewed.
  • [ ] Checked and agree with release testing considerations added to MR for the next release.

Closes JIRA Issue

Closes AUR-47

JuliaRonnebergerUL avatar Sep 30 '22 12:09 JuliaRonnebergerUL

@JuliaRonnebergerUL Can we comment public methods please? Also can you draft documentation for this, like the Core examples? I know it's preview but would be great to get the documentation done now while it's still fresh. Thanks.

MaxPalmer-UH avatar Oct 14 '22 08:10 MaxPalmer-UH

@JuliaRonnebergerUL thanks for the changes. Looking really nice. One thing to put in the docs is an explanation of how to switch pinch to paint to the left hand. Happy to merge.

MaxPalmer-UH avatar Oct 20 '22 08:10 MaxPalmer-UH