new module from scratch: bluetooth2

[lasers]

This adds more placeholders, colors, formats, etc. Made this long time ago. Still working fine today.

Closes #1862.

[lgtm-com[bot]]

This pull request fixes 1 alert when merging 38765226cb562b53aabc6bfa7982b83e6616c0c0 into 2f879ce567b97ca9540d242ddd32a532b834c521 - view on LGTM.com

fixed alerts:

• 1 for First parameter of a method is not named 'self'

[ultrabug]

Could you make the defaults to be backward compatible for current users?

[lasers]

Probably not because I forget things. At a glance, it looks like the (default) parity will be mostly same, but not existing config. Also, because there is an existing / old backward compatible code already in there. This one just takes everything off.

I wonder if I should keep the names green (connected) or just leave it blank (default color). Probably OK either way. I have included a legacy format in EXAMPLES should users want to add prefix BT.

This gets rid of pydbus too and adds a new dependency... so no point in keeping it backward compatible.

[ultrabug]

Now I'm always reluctant to modules rewrite not being backwards compatible tbh

Since it's a rewrite, please align license with BSD, also I'd rather let people choose their colors

[lasers]

Changed to @license BSD. EDIT: As for colors, I'm talking about default blank versus default green. Either way, it's good.

[lgtm-com[bot]]

This pull request fixes 1 alert when merging ea4f1c9f23506b74aed85673c0dbd0f956118544 into 40cff114a4ed443d38a9ab64c1d781fd5dacc741 - view on LGTM.com

fixed alerts:

• 1 for First parameter of a method is not named 'self'

[lasers]

@ultrabug Is there anything else I have to do here?

[anarcat]

i'm not a maintainer here but i would suspect that a backwards-incompatible change would at least warrant a warning in the CHANGELOG. alternatively, it should be made backwards-compatible, or maybe just renamed (bluetooth2?)?

[ultrabug]

I agree with @anarcat ; I can't get around the idea of breaking current users' modules

So, let's rename it to bluetooth2 and add a deprecation warning on the other + CHANGELOG notice; then in a version or two, we'll do the switch.

[lasers]

As requested, I renamed this to bluetooth2.py. You can take over for deprecation warning + CHANGELOG notice since I am unsure how to proceed from here as we already did some deprecation warnings in the past. Cheers.