ngx-errors
ngx-errors copied to clipboard
ultimatecourses
L96 GitHub working patch to rxjs 6
What are you adding/fixing?
Attempting to make it compatible with rxjs version 6, mostly using rxjs-compat.
Have you added tests for your changes?
Not yet. Unfortunately didn't have enough time.
Will this need documentation changes?
No, although the changes are on how rxjs imports are structured and the new ways of using its components (e.g. combineLatest, Observable, Subject, map, etc). There is plenty of docs describing the changes. (https://auth0.com/blog/whats-new-in-rxjs-6/), but that doesn't directly concern this package
Does this introduce a breaking change?
So far none apparent. I am currently using it in a project almost in production.
Other information
I ran the example with yarn example and tested it, had no errors on the console. Had to update the code to support the braking changes of rxjs 6, other than a few warnings (as you can see in the screenshots) I have not come across any problem. I am also testing as much as I can on the project in which I am using it on, hope it helps.
would be great to have support for RxJS 6. Currently can't use it in Angular 7. Anyone know of a workaround ? thanks
would be great to have support for RxJS 6. Currently can't use it in Angular 7. Anyone know of a workaround ? thanks
You can use rxjs-compat during the time where you wait the approval of this PR ;)
