Ulrik Falklöf
Ulrik Falklöf
#696 is now rebased.
Thanks @haxorz Deleting these outputs via bazelisk (or similar) would require bazel to expose the mapping between build outputs and workspaces. Right? But bazel’s README files warns about trying to...
@fmeum, can you elaborate on "_moves of files extracted from tars_"? If we run stat on "path" before and after the following moves: ``` mv path newLocation mv otherFile path...
Thanks @fmeum, interesting, I take a look.
It was a mystery to me how the inode number could stay the same after tar called unlinkat: ``` openat(4, "template1", O_WRONLY|O_CREAT|O_EXCL|O_NOCTTY|O_NONBLOCK|O_CLOEXEC, 0644) = -1 EEXIST (File exists) unlinkat(4, "template1",...
The ctime value changes not only when sandboxes create hard links but also when those links are removed. It seems challenging to update the cache in DigestUtils **atomically** with ctime...
> but it would also become quite hard to explain what kind of file changes are tracked and which aren't. What if explained as the following? * Files written by...
I wonder why Bazel has explicit code to manipulate mtime when archives are **extracted**? (e.g. via repository_ctx.extract) Wouldn’t it make more sense for Bazel to avoid faking mtime when extracting...
> I would prefer a solution that replaces hardlinks with reflinks (automatically used by FileSystemUtils.copyFile if supported), but I haven't benchmarked it yet. If your benchmark of copy-on-write will show...
> I don't think Bazel does that, see > > [bazel/src/main/java/com/google/devtools/build/lib/bazel/repository/decompressor/ZipDecompressor.java](https://github.com/bazelbuild/bazel/blob/92de49c53bd00bfd0eea28f1ad510f057ffbe6bf/src/main/java/com/google/devtools/build/lib/bazel/repository/decompressor/ZipDecompressor.java#L172) > > Line 172 in [92de49c](/bazelbuild/bazel/commit/92de49c53bd00bfd0eea28f1ad510f057ffbe6bf) > > outputPath.setLastModifiedTime(entry.getTime()); ... Maybe we have different interpretations of the word “manipulation,”...