Ulrich Müller

> @dlan17 ,@ulm , we use the content of the `.deb` only. It states that the license is exactly GPL-3. > > I understand that it is an upstream error...

> > the code from the `bitwarden_license` directory is needed to build the binary. > > Technically we you don't know how `.deb` was created. But have the `control` file...

And of course, it is _our_ responsibility that the `LICENSE` information of the ebuild is correct.

> Hi, i'm the openSUSE maintainer of the bitwarden package. > > 2024.9.0 and below are AFAICT all freely licensed. The _new_ offending code is not in the `bitwarden_license` directory...

There should be separate commits for `assert` and `pipestatus` as well as separate feature test functions.

> > There should be separate commits for `assert` and `pipestatus` as well as separate feature test functions. > > I feel like banning `assert` and introducing `pipestatus` should be...

Two more comments: 1. Why do you define the functions in a separate `eapi9-pipestatus.sh` file instead of `isolated-function.sh`? It seems unnecessary. 2. Please don't define `pipestatus` and then unset it...

> > 1. Why do you define the functions in a separate `eapi9-pipestatus.sh` file instead of `isolated-function.sh`? It seems unnecessary. > > Having the code isolated in a single file...

> Sourcing the file conditionally has disadvantages, as it's` __pipestatus` is used internally by portage as EAPI agnostic `assert`/`pipestatus`. If it would only be available in certain EAPIs, then we...

> The man page updates have been added with #1453 but the remaining issues, namely portage usage of `assert` likely failing if `EAPI=9` and no tests, are still unfixed Hopefully...