ryu icon indicating copy to clipboard operation
ryu copied to clipboard

Label commits to C source

Open Ninds opened this issue 5 years ago • 2 comments
trafficstars

Hi. Going forward, would it be possible to 'label' any commits or issues targeting the C implementation? This would greatly help in keeping in sync any ports of the C implementation that aim to track as close as possible the original C source here.
I forked RyuCsharp to create Ryu.NET and have been able to port over two bugfixes that postdate the creation of RyuCsharp.

Thanks N

Ninds avatar Jul 02 '20 20:07 Ninds

I'm not sure how that would work. I assume you want to be notified if there's a change that might affect your port?

(I just pushed a bugfix to the 128-bit implementation.)

ulfjack avatar Jul 10 '20 09:07 ulfjack

I'm not sure either how notifications would work and even if it's possible. However, I was thinking more along the terms of simply using labels. That way the commits to the C source would be easily marked. Of course one would have to manually scan the issues periodically but that doesn't seem like a blocker Thanks

EDIT : Oops, I've just seen that you already have labels.

Ninds avatar Jul 10 '20 10:07 Ninds