data-workspace-frontend icon indicating copy to clipboard operation
data-workspace-frontend copied to clipboard

Published 20 hours ago • verified publisher icon uktrade

refactor: use pg-sync-roles for creating and maintaing database users

Open michalc opened this issue 1 year ago • 0 comments

Description of change

This is technically a refactor given the existing behaviour of pg-sync-roles, and it doesn't give that much. However, in later changes we'll

  • Be moving more logic into pg-sync-roles
  • Fixing an issue that results in an accumulation of roles on tables

The increase of depenency versions are due to the older version of elastic-apm monkey patching psycopg2 in a way that breaks pg-sync-roles. It would result in an error:

argument 1 must be psycopg2.extensions.connection, not PGConnectionProxy

I think when calling psycopg2's sql.SQL as_string function.

And then the bump of other versions were a consequence of the elastic-apm version bump.

Checklist

  • [ ] Have tests been added to cover any changes?
  • [ ] Have E2E tests been added to cover any React changes?
  • [ ] Have Accessibility tests been added to cover any React changes?

michalc avatar May 10 '24 15:05 michalc