vigra icon indicating copy to clipboard operation
vigra copied to clipboard

Published 20 hours ago • verified publisher icon ukoethe

Fix CIs

Open hmaarrfk opened this issue 2 years ago • 5 comments

I spoke with ukoethe by email and he agreed that dropping python 2.7 would be ok.

Closes: https://github.com/ukoethe/vigra/issues/502

hmaarrfk avatar Oct 22 '22 17:10 hmaarrfk

100% tests passed, 0 tests failed out of 55

hmaarrfk avatar Oct 23 '22 12:10 hmaarrfk

@k-dominik I am trying to keep this to a "CI only change" and I think I'm close.

I'm struggling with windows. If you have a machine handy and want to debug that would be greatly appreciated.

OSX is close, but for some reason i'm getting a segfault. fun!

hmaarrfk avatar Oct 24 '22 13:10 hmaarrfk

Hi @hmaarrfk,

awesome effort! I'll look into the windows build tomorrow :)

k-dominik avatar Oct 24 '22 13:10 k-dominik

Hi @hmaarrfk,

is there a reason for the testing strategy with OSX-> py37, linux-> py38, py39, and windows-> py310?

k-dominik avatar Oct 24 '22 13:10 k-dominik

is there a reason for the testing strategy with OSX-> py37, linux-> py38, py39, and windows-> py310?

Just trying to get a "spread" of python versions without building the full matrix. 3 x 4 -> 12 builds is a little "too much".

hmaarrfk avatar Oct 24 '22 13:10 hmaarrfk

@k-dominik i'm somewhat tempted to skip OSX and merge this as is. what do you think? There seems to be a few more PRs to modernize the code base that would go through more easily once we have linux + windows CIs in place.

hmaarrfk avatar Feb 19 '23 23:02 hmaarrfk

Hello @hmaarrfk,

yes, let's go ahead and merge this. I am always thinking of getting back to vigra and I promise I will ;). Thank you for persisting here!

Cheers Dominik

k-dominik avatar Feb 24 '23 13:02 k-dominik