vigra icon indicating copy to clipboard operation
vigra copied to clipboard

Published 20 hours ago • verified publisher icon ukoethe

cpp11

Open lnw opened this issue 2 years ago • 1 comments

Silence Wdeprecated-copy warnings by g++-11/linux. Breaks any pre-11 c++ versions!

The choice of defaulting/deleting member function simply replicates the previous implicit choices. The two lines in multi_array.hxx and numpy_array_taggedshape.hxx may warrant some looking at (although also here, I'm just replicating the previous implicit behaviour)

lnw avatar Jun 14 '22 21:06 lnw

I see that most of the checks have failed. Looking at the errors, it looks to me like that's a problem of the setup and has nothing to do with the patch.

lnw avatar Jun 15 '22 16:06 lnw

We have started to "revive" the project now that we got some CIs working again. If you wanted to rebase onto master, that would be great and we can test again.

hmaarrfk avatar Sep 30 '23 18:09 hmaarrfk

Rebased and testing in https://github.com/ukoethe/vigra/pull/544

hmaarrfk avatar Sep 30 '23 19:09 hmaarrfk

thank you!

hmaarrfk avatar Sep 30 '23 19:09 hmaarrfk

I see you were faster than me, thanks!

We have started to "revive" the project now that we got some CIs working again. If you wanted to rebase onto master, that would be great and we can test again.

lnw avatar Sep 30 '23 21:09 lnw