vigra Complete quoting for parameters of some CMake commands

Some parameters (like "${vigra_SOURCE_DIR}/include" and "${DOCDIR}") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

Mar 23 '16 18:03 elfring

Do you have a concrete example where VIGRA's build scripts fail? To my knowledge, the lines you are pointing out above have never been the source of any prolems.

Mar 23 '16 20:03 ukoethe

Do you care for the potential around occurrence of semicolons in the contents of CMake variables?

Mar 24 '16 10:03 elfring

I care very much about the reliability of the build scripts and fixed every known failure. However, the examples you cited refer to path names that don't ever contain semicolons, and there was no bug report. There is no point in complaints from a language lawyer's perspective, you have to demonstrate the failure possibility with a realistic counter example.

Mar 24 '16 10:03 ukoethe

Do you find information from another bug report interesting?

Mar 24 '16 11:03 elfring