Clive Cox comments

Results 246 comments of


                                            Clive Cox

Inconsistency of the notebook model used in GPT2 notebooks

@adriangonz any ideas?

set canary traffic with 100:0 but got 50:50

In general, when you want to do the final choice you would reapply with the chosen predictor not with one set to zero traffic. This may be connected to [this](https://github.com/istio/istio/issues/15157)...

set canary traffic with 100:0 but got 50:50

Needs further investigation before closing

OSS-124: Allow annotations to HPAs created from CRD

Ok this sounds useful and a small addition. Will add to next release roadmap.

OSS-124: Allow annotations to HPAs created from CRD

Would would like to allow users to define HPAs in V2 API we are investigating.

OSS-124: Allow annotations to HPAs created from CRD

OK great. @mwm5945 Useful to know.

clusterDomain can written in configuration from seldondeployment controller

Are you able to suggest a modification for this code to derive the current domain?

Add support for /v2/models/{model name}/config endpoint in Executor

I think there are some things we need to consider before adding * If this is just Triton it will be confusing to users if MLServer does not support this....

Pod Level Labels and Annotations are not applied correctly

Yes, we need to look further into cleaning up these areas post 1.1

Pod Level Labels and Annotations are not applied correctly

The annotations and labels should be added with precedence given for inner ones over outer. See: https://github.com/SeldonIO/seldon-core/blob/82a8317f2c37dc19705e4c57a56e0447938e18d1/operator/controllers/seldondeployment_controller.go#L813-L846 Can you check in 1.1.0 release.