afwall icon indicating copy to clipboard operation
afwall copied to clipboard

[ISSUE] v3.6.1 not available in F-Droid store (build fails)

Open WhoAmI0501 opened this issue 1 year ago • 10 comments

Describe the bug The version v3.6.1 of afwall is not available in the F-Droid store. An auto updater updated it (see MR/commit), but the build failed (see logs) and an maintainer from f-droid just disabled the new version (see commit).

WhoAmI0501 avatar Jan 01 '25 20:01 WhoAmI0501

Hey @ukanth, can you have a look on this?

WhoAmI0501 avatar Jan 13 '25 09:01 WhoAmI0501

Hey @ukanth yes pls !!!

acidhexe avatar Apr 16 '25 10:04 acidhexe

Will look into it this week.

ukanth avatar Aug 30 '25 08:08 ukanth

Maybe its fixed with the new Major Version! 🥳

Revan335 avatar Oct 02 '25 23:10 Revan335

I doubt I can support f-droid builds anymore. Building these binaries using their infra is harder. I added support of building binaries using github. If they allow supporting pre-built binaries from github, then I can fix it.

ukanth avatar Oct 03 '25 02:10 ukanth

Maybe with a Own F-Droid Repository than we can added this as separated or @IzzySoft https://apt.izzysoft.de/fdroid/index/info can added this to his own.

Revan335 avatar Oct 03 '25 08:10 Revan335

Or he @IzzySoft https://github.com/IzzySoft supported you for adding for his Repository!

Actually we have only Google Play Store/Aurora Store for your App included Updates/Update Functionality!

And only Google Play Store to https://github.com/ukanth/afwall/issues/1432 for buying the Donated Version or the Donated License to Unlock this in the Main App!

I don't know is F-Droid supporting pre-built binaries from github. A Developer or others Experts can speak more about this.

Revan335 avatar Oct 12 '25 01:10 Revan335

I don't know is F-Droid supporting pre-built binaries from github.

It does not. What binaries are we talking about? We could take a look whether we can take it in to our repo. APK size fits, scanner results are mostly OK (the Locale plugin would raise NonFreeAdd maybe) – only this one should preferably be addressed with the next release:

SigningBlock blobs:
-------------------
0x504b4453 (DEPENDENCY_INFO_BLOCK; GOOGLE)

Easily done by adding a few lines to build.gradle:

android {
    dependenciesInfo {
        // Disables dependency metadata when building APKs (for IzzyOnDroid/F-Droid)
        includeInApk = false
        // Disables dependency metadata when building Android App Bundles (for Google Play)
        includeInBundle = false
    }
}

For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains. More details can be found e.g. here: Ramping up security: additional APK checks are in place with the IzzyOnDroid repo.

Ah, I see the binaries directory. Where do those binaries originate? I see there is a build-binaries.yml for a Github action. So maybe git clone › rm -f binaries/* › run build-binaries workflow › run android workflow should produce the (hopefully identical) APK? But would that even be needed? I don't see e.g. the busybox binary in the APK.

IzzySoft avatar Oct 12 '25 09:10 IzzySoft

Maybe @ukanth its Izzy's Answer helpful for you or you are talking about the adding/Update Process.

Revan335 avatar Oct 12 '25 09:10 Revan335

or you are talking about the adding/Update Process

Just saying: should those binaries not be needed to build the APK (as I wrote, it seems they are not included), adding AFWall to IzzyOnDroid should be easy, and (hopefully) straight forward.

IzzySoft avatar Oct 12 '25 10:10 IzzySoft