fountainpencompanion icon indicating copy to clipboard operation
fountainpencompanion copied to clipboard

Published 20 hours ago • verified publisher icon ujh

Upgrade to recharts 2

Open ujh opened this issue 2 years ago • 4 comments

Right now we cannot upgrade to recharts 2 as it fails with the error described in https://github.com/ujh/fountainpencompanion/pull/1329. However, when the fix is applied, the admin area macro cluster app then fails with the exact error. It seems that we can only have it one way or the other.

ujh avatar Jan 13 '23 07:01 ujh

FYI, @wkillerud.

ujh avatar Jan 13 '23 07:01 ujh

Oh, that's a shame. Didn't think to test that, sorry 😅

wkillerud avatar Jan 13 '23 07:01 wkillerud

That is totally not your fault! It did fix the user visible part, so that was highly appreciated so that I could go to bed last night. 😉

ujh avatar Jan 13 '23 07:01 ujh

In the end it comes down to the abysmal code coverage on the JavaScript side that let's stuff like that slip through. Something I would never accept at work, but here ... oh, well. 😬

ujh avatar Jan 13 '23 07:01 ujh