ico icon indicating copy to clipboard operation
ico copied to clipboard

Published 20 hours ago • verified publisher icon uiteoi

bar_label option

Open LINKE opened this issue 13 years ago • 4 comments

add bar_label option to support labels on top/bottom/left/right of bars

LINKE avatar Jul 27 '11 15:07 LINKE

Thank you very much Linke for the pull request.

My initial comments are:

  • The option is on by default, I think it should be off.
  • The option does not display nicely on horizontal bars and can overlap on labels. This needs to be fixed to keep the high level of quality that I am trying to provide and as Ico is used in production systems. This probably requires some design thoughts considering the real-estate challenge. The same problem would hold true for value tooltips on mouseover to a lesser extent, and this is the very reason I have not yet implemented these.
  • For the sake of consistency, the option should also be available for line graphs, it can be done by implementing it as an Ico.Component which are automatically reused for all Graph classes.
  • End-users should be able to specify font-attributes, this can be easily done in a component which has its own options and default.
  • Units can be displayed before or after the value based on the option "units_position" ($ is displayed before), the function format_value() takes care of this.
  • The name of the option will need to be changed to something more descriptive and unambiguous. I don't have a good name at this time but will keep thinking about it.
  • The documentation will need to be updated.

uiteoi avatar Jul 27 '11 16:07 uiteoi

LINKE, I still do not have an acceptable solution to the above issues and therefore cannot pull the request at this time.

Did you make any progress on your side?

uiteoi avatar Aug 15 '11 21:08 uiteoi

Hi, i'm sorry, i'm very busy these days. so no spare time to handle these issues. i will try to fix it later...

Thanks linke

Date: Mon, 15 Aug 2011 14:15:58 -0700 From: [email protected] To: [email protected] Subject: Re: [ico] bar_label option (#1)

LINKE, I still do not have an acceptable solution to the above issues and therefore cannot pull the request at this time.

Did you make any progress on your side?

Reply to this email directly or view it on GitHub: https://github.com/uiteoi/ico/pull/1#issuecomment-1811169

LINKE avatar Aug 16 '11 07:08 LINKE

Hi Linke,

Just to let you know, I now intend to implement dynamic tooltips that will position themselves properly in all cases.

Regards, Jean.

uiteoi avatar Nov 30 '11 23:11 uiteoi