wdi5
wdi5 copied to clipboard
Feat/deprecate url property
Hey @vobu and @dominikfeininger what do you think about my PoC here to remove/deprecate the wdi5 specific url
property and only rely on the wdio baseUrl
property in the future.
Of course there are still few things to consider but shouldn't that be possible or am I missing something?
Getting mixed vibes here. On the one hand, I'm always pro simplification and deleting code 😆 This would be achieved mostly by omitting the necessary url
prop.
On the other hand, I like the verbosity of explicitly setting the bootstrap html page - descriptive and clear config. Plus with wdi5
just taking off, I'm hesitant with introducing an (from the outside) seemingly unnecessary change.
To sum it up → I don't have a clear opinion pro/contra omitting url
from the config.
Suggestion: let's ask the steering committee, that's what they're here for :)
Hi Volker,
great Idea! Just my two cents why I proposed this change and then it's up to the steering committee:
- I often get the feedback that it is quite confusing for people to understand the sense of the additional
url
property when just passing the whole path to thebaseUrl
also works perfectly fine. Especially when testing applications in the Launchpad where we don't have an.html
file, people get confused. - When you want to dynamically pass the url to the deployed application via cli like
wdio run --baseUrl=mydeployedApplication
it is almost necessary to leave theurl
with an empty string and pass the full path in thebaseUrl
property or use environment variables. - If we don't have a mandatory wdi5 property in the config anymore, the guided installation of
wdio
also installs and configures everything we need to directly run our tests.
Regards, Simon
Hi, a comment from the initial creation of this property (which should end up in the code after this discussion or refactoring? ).
https://github.com/ui5-community/wdi5/blob/8b4d49fdd2d396ec566a8ed2a46e61d0e795ee78/src/lib/wdi5-bridge.ts#L284
The goTo
uses the url parameter for some url manipulating. Not 100% sure at the moment when is's needed and what it does. But it's related to the fact, that some application servers need to have index.html
written in the url. Maybe its just legacy from the wdi5 hybrid part.