wdi5 icon indicating copy to clipboard operation
wdi5 copied to clipboard

Feature/chromedriver update

Open dominikfeininger opened this issue 2 years ago • 5 comments

since already noticed that a chromedriver update might be required to execute the tests if the local chrome was updated silently.

happy to see suggestions for improved parsing.

dominikfeininger avatar Mar 11 '22 10:03 dominikfeininger

let's make this cross-platform before it's good to go

vobu avatar Mar 11 '22 13:03 vobu

converting to draft as this needs cross-platform enhancement

vobu avatar Mar 14 '22 11:03 vobu

https://superuser.com/questions/1144651/get-chrome-version-from-commandline-in-mac

dominikfeininger avatar Apr 13 '22 06:04 dominikfeininger

solution from UiVeri5 by @hmanchev

In UIVeri5 we implemented primitive solution for controlling the (chrome)driver version. We have one JSON file in the root of the repo, which is controlled by us and then is used to get the specified chromedriver version. It is not the best solution, but we agreed that is most stable.

The approach in the Dominik’s PR is looking problematic for me. From my experience of supporting UIVeri5, I have seen a lot of different setups – local and ci/cd. So I think you can’t cover all cases to get the Chrome browser version – different OS, consider docker env where the browser can be installed in many different ways/paths. Also, the versions of browser and driver are not the same – build versions are different.

We have a Docker setup which relies on the latest chrome + driver and that’s how we implemented it: Get the chrome browser major version (for example 100, or 99) – we know where the browser is installed. GET request to: https://chromedriver.storage.googleapis.com/LATEST_RELEASE_<major_version> It returns the latest driver version for the requested browser major version:

Second similar approach is to get the latest version of chrome driver for the stable browser version: https://chromedriver.storage.googleapis.com/LATEST_RELEASE

From my experience, again, it is always a good approach to provide an easy way to the users to control the driver version by themselves. In your case, probably good description in the docs.

dominikfeininger avatar Apr 20 '22 07:04 dominikfeininger

hi @hmanchev, since you already provided the solution I would appreciate your help here ;)

dominikfeininger avatar May 18 '22 07:05 dominikfeininger

solved by using "chromedriver": "latest"

dominikfeininger avatar Nov 07 '22 11:11 dominikfeininger