Eugene Lazutkin
Eugene Lazutkin
I am not a TS expert, so help is wanted.
Until GitHub Actions provide ARM-based Windows and Mac runners, I don’t see how it can be done. Closing for now.
It looks like alternative ways to build a binary extensions are more mature now. Specifically WASM looks like an interesting option. Closing this issues for two reasons: * There are...
I am not using it with TS, so I suggest to check with heavy TS users how to import this library properly. PS: Good thing you did try it with...
The code is in https://github.com/uhop/node-re2/tree/kachick-add-ts-tests branch. It includes the minimal fix from #141. It fails to compile with the latest Typescript. I am not sure how to handle a type...
Moving the development to #142.
You do aware that this function is quadratic: ```js function matchAll(input, regex) { return [...input.matchAll(regex)]; } ``` Specifically, the `[...iterator]` part, which adds new elements at the end reallocating its...
> As far as I know appending to an array is amortized constant because it only has to reallocate a logarithmic number of times. No different from `std::vector`. I think...
It is good actionable data. We can consider moving it to C++, or switching to a buffer version in JS. TBH, the C++ implementation is the bigger endeavor that can...
@matthewvalentine please verify that it scales better now. I did my own benchmarking with this code: ```js 'use strict'; const RE2 = require('./re2.js'); const sample = 'a'.repeat(100_000); const re =...