Igor Malinovskiy

Results 100 comments of Igor Malinovskiy

Hey @itamarhaber, I thought that we are trying to avoid slavery words and tried to exclude it, at least in the request_policy name. It makes sense to remove all "master"...

@itamarhaber In the original text, we use "shard" as a synonym for "master": > **all_shards:** the client should execute the command on all **master** shards That's why I used `any_shard`...

@oranagra clients now interpret it as "execute all the time on the same/first shard." In most cases, it should be some round-robin to distribute the load. Do you think there...

@ramchandra-st Looks like you are using an old version of hiredis-py. I recommend upgrading redis-py to the latest version and ensuring that hiredis-py is updated as well.

> I don't want to merge this until these commands actually land in redis, but we can certainly take a look at the proposal in advance of that 👍 Redis...

@NickCraver Could you merge this PR?

@mgravell @NickCraver Could you review and merge this change so we can actually test 7.4 related PRs in CI? Pending 7.4 PRs: https://github.com/StackExchange/StackExchange.Redis/pull/2716 https://github.com/StackExchange/StackExchange.Redis/pull/2722 https://github.com/StackExchange/StackExchange.Redis/pull/2727

| Testcase | Errors | Failures | Skipped | Total | |---------------------------------------------------------|----------|------------|-----------|---------| | redis.clients.jedis.scenario.ConnectionInterruptionTest | 0 | 0 | 0 | 4 | | redis.clients.jedis.scenario.ClusterTopologyRefreshTest | 0 | 0 |...