Nick Logan

Results 307 comments of Nick Logan

I'm not sure if all of these changes are sufficient or correct. Technically the minimum I needed to resolve the issue mentioned in the OP is: ``` diff --git a/src/strings/decode_stream.c...

> Wouldn't that break 32bit builds? Or don't we support those anymore anyway? Not sure. There are already other instances of `MVMint64`, for example https://github.com/MoarVM/MoarVM/blob/f4680765ff33c5815a8a9ae183ed08cce6cc6943/src/strings/decode_stream.h#L105

Have you tried using it directly as the warning message suggests? The code you posted does not use it directly as it is interpolated and so the warning is expected.

I looked at your code and it is trying to treat an e.g. `Distribution::Resources` object as if it were a path, but we make no such claim as these things...

Do not do “the trick” above. The warning is telling users about a very real problem and working around it the way you suggest is going to make users more...

> By the way, could you explain why this method of IO() is available and not also deprecated? Arguably it could be deprecated. `Distribution::Resource::IO()` does not precompile a path into...

You need to have the environment variable e.g. `$SHELL` set to something so it knows what shell to spawn. zef should probably exit with an error stating that.