ufs-weather-model icon indicating copy to clipboard operation
ufs-weather-model copied to clipboard

sync with head of NOAA-EMC UPP develop

Open SamuelTrahanNOAA opened this issue 8 months ago • 12 comments

Commit Queue Requirements:

  • [x] Fill out all sections of this template.
  • [ ] All sub component pull requests have been reviewed by their code managers - no fv3atm reviews yet
  • [x] Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • [x] Commit 'test_changes.list' from previous step

Description:

  1. Sync FV3/upp with the head of its authoritative branch.
  2. Update library g2tmpl to version 1.12.0
  3. Inline post FV3/io/post_FV3.F90 is updated for the new UPP.
  4. Add number concentration fields to the gnv1_nested regression test.
  5. Update the UPP control files for global, rrfs and hafs used in inline post in regression tests.

Syncing to the top of FV3/upp brings in many bug fixes and new features. Users must update their build systems and static files due to this update.

After this update, users must...

  1. Update to g2tmpl version 1.12.0.
  2. Ensure ufs-weather-model/modulefiles, FV3/io/post_FV3.F90, and FV3/upp are all updated in their forks.
  3. Regenerate postxconfig*.txt files if running the inline post.

The reasons users must update are...

  1. Some RRFS-specific variables change from GRIB template 4.8 to 4.9. This requires a newer version of g2tmpl. Also, it requires changes to postxconfig*.txt files if you use those variables. GRIB records for those variables will change to, so it will affect downstream users who use those fields.
  2. As a cleanup measure, variable names for number concentration on hybrid levels no longer have the "GSL_" prefix. Your postxconfig*.txt files must update to match, if you use those variables.
  3. UPP's EBB variable changed from 2D to 4D. This requires a change to FV3/io/post_FV3.F90 to send CCPP's ebu_smoke to UPP's EBB. That change is not backward-compatible to older versions. Both post_FV3.F90 and UPP must update at the same time.

Commit Message:

* UFSWM - update g2tmpl, update UPP hash, sync parm files with new UPP version
  * FV3 - update inline post for UPP

Priority:

  • Normal

Git Tracking

UFSWM:

  • #2322
  • #2321

Sub component Pull Requests:

  • FV3: https://github.com/NOAA-EMC/fv3atm/pull/845

UFSWM Blocking Dependencies:

  • Library installation directories must contain g2tmpl 1.12.0 for both compilers
    • https://github.com/ufs-community/ufs-weather-model/issues/2322

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines - any FV3 test that uses the inline post may have changed GRIB output.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • Required
    • Library names w/versions: g2tmpl version 1.12.0
    • Git Stack Issue - none; changes are already merged

This is already in Spack Stack, and ported to some platforms, but must be added to ufs-weather-model's Spack Stack directories.


Testing Log:

  • RDHPCS
    • [ ] Hera
    • [ ] Orion
    • [ ] Hercules
    • [ ] Jet
    • [ ] Gaea
    • [ ] Derecho
  • WCOSS2
    • [ ] Dogwood/Cactus
    • [ ] Acorn
  • [ ] CI
  • [ ] opnReqTest (complete task if unnecessary)

SamuelTrahanNOAA avatar Jun 13 '24 21:06 SamuelTrahanNOAA