ufs-weather-model
ufs-weather-model copied to clipboard
Add support for optional arguments in ccpp physics and framework
Commit Queue Requirements:
- [x] Fill out all sections of this template.
- [x] All sub component pull requests have been reviewed by their code managers.
- [x] Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
- [x] Commit 'test_changes.list' from previous step
- [x] I couldn't -
test_changes.list
was empty from previous PR, and since my PRs don't change results I can't commit an unmodified file (see https://github.com/ufs-community/ufs-weather-model/pull/2205/commits/5588f99715cf16d9c7cb8d35314ffb4e9dd0c00a)
- [x] I couldn't -
Description:
This set of PRs adds support for optional arguments in CCPP physics schemes to the metadata and framework, with related changes in fv3atm, gfdl_atmos_cubed_sphere, and stochastic_physics.
Commit Message:
* UFSWM - Add support for optional arguments in ccpp physics and framework
* AQM -
* CDEPS -
* CICE -
* CMEPS -
* CMakeModules -
* FV3 - [Add support for optional arguments in ccpp physics and framework](https://github.com/NOAA-EMC/fv3atm/pull/807#top)
* ccpp-physics - Introduce optional arguments in ccpp schemes and metadata
* ccpp-framework - Add support (and tests) for optional arguments in ccpp_prebuild
* atmos_cubed_sphere - Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90
* GOCART -
* HYCOM -
* MOM6 -
* NOAHMP -
* WW3 -
* stochastic_physics - Add optional attribute for variables where necessary
Priority:
- High: Timeline - my transition to NRL (selfish, I know, sorry) and another large set of PRs (conversion to contiguous arrays) waiting for these changes
Git Tracking
UFSWM:
- Resolves https://github.com/NCAR/ccpp-framework/issues/526
- Resolves https://github.com/NCAR/ccpp-framework/issues/540
Sub component Pull Requests:
This is part of a large set of PRs:
https://github.com/NCAR/ccpp-framework/pull/552 https://github.com/NOAA-EMC/fv3atm/pull/807 https://github.com/ufs-community/ufs-weather-model/pull/2205 https://github.com/ufs-community/ccpp-physics/pull/189 https://github.com/NCAR/ccpp-framework/pull/556 (can be scheduled and merged anytime beforehand) https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/338 https://github.com/NOAA-PSL/stochastic_physics/pull/79
UFSWM Blocking Dependencies:
All sub-component PRs listed above
Changes
Regression Test Changes (Please commit test_changes.list):
- No Baseline Changes - everything is bit-for-bit identical!
Input data Changes:
- None.
Library Changes/Upgrades:
- No Updates
Testing Log:
- RDHPCS
- [ ] Hera
- [ ] Orion
- [ ] Hercules
- [ ] Jet
- [ ] Gaea
- [ ] Derecho
- WCOSS2
- [ ] Dogwood/Cactus
- [ ] Acorn
- [ ] CI
- [ ] opnReqTest (complete task if unnecessary)
@jkbk2004 This PR and sub-component PRs are finally ready for review. Everything is b4b identical!
@climbfuji sounds good! we will try to schedule to commit sometime next week.
Hi @climbfuji, this PR is next for testing, please go ahead and sync / reesolve merge conflicts. Please also merge in changes from #2286, there should be no baseline changes from that PR as well.
Well, there are several merge conflicts in ccpp-physics. This will take a bit to resolve :-(
I think I got it - let me run a quick compile of all suites on my mac
@FernandoAndrade-NOAA I think this is good now. It compiled successfully on my macOS. I didn't run any tests on Hera after merging in the latest changes from develop and @jiandewang's PR.
@BrianCurtis-NOAA @zach1221 FYI getting started with RTs for this PR.
@climbfuji can you modify tilte for this PR to add "Add end of run restart functionality to MOM6 #2286" ? Thanks
@climbfuji can you modify tilte for this PR to add "Add end of run restart functionality to MOM6 #2286" ? Thanks
Of course, done!
@climbfuji can you modify tilte for this PR to add "Add end of run restart functionality to MOM6 #2286" ? Thanks
Of course, done!
thanks. You modified the title as fast as lighting
@FernandoAndrade-NOAA can you bring in the PR information from the combined PR into this one?
Ok, we should be all set to continue the merge process, I'll leave a note on the component PRs.
Ok, we should be all set to continue the merge process, I'll leave a note on the component PRs.
time ot merge MOM6 ?
Ok, we should be all set to continue the merge process, I'll leave a note on the component PRs.
time ot merge MOM6 ?
Yes please go ahead and merge in MOM6, we should be all set there.
just merged MOM6. Hash # b32aea7bf3
fv3atm should be ready to merge, please check
fv3atm should be ready to merge, please check
All component PRs merged in, please go ahead and revert gitmodules / update hashes, thanks!
Thanks for shepherding this PR set through - should be good to go