ufs-weather-model icon indicating copy to clipboard operation
ufs-weather-model copied to clipboard

Change the default value of INLINE_POST build option

Open DusanJovic-NOAA opened this issue 2 years ago • 2 comments

The default value of INLINE_POST build option is currently OFF:

$ grep INLINE_POST CMakeLists.txt 
set(INLINE_POST     OFF CACHE BOOL "Enable inline post")
message("INLINE_POST ...... ${INLINE_POST}")

However in all cmake/configure_*.cmake files we override this and set INLINE_POST to ON:

$ grep INLINE_POST cmake/*
cmake/configure_acorn.cmake:set(INLINE_POST     ON  CACHE BOOL "Enable inline post" FORCE)
cmake/configure_cheyenne.gnu.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_cheyenne.intel.cmake:set(INLINE_POST     ON  CACHE BOOL "Enable inline post" FORCE)
cmake/configure_expanse.intel.cmake:set(INLINE_POST     ON  CACHE BOOL "Enable inline post" FORCE)
cmake/configure_gaea.intel.cmake:set(INLINE_POST     ON  CACHE BOOL "Enable inline post" FORCE)
cmake/configure_hera.gnu.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_hera.intel.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_jet.intel.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_linux.gnu.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_linux.intel.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_macosx.gnu.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_macosx.intel.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_orion.intel.cmake:set(INLINE_POST     ON  CACHE BOOL "Enable inline post" FORCE)
cmake/configure_s4.intel.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_stampede.intel.cmake:set(INLINE_POST     ON CACHE BOOL "Enable inline post" FORCE)
cmake/configure_wcoss2.cmake:set(INLINE_POST     ON  CACHE BOOL "Enable inline post" FORCE)

It makes more sense to set the default value to ON, and remove all these settings from all cmake/configure_*.cmake files. Users will still be able to turn the inline post off by explicitly setting INLINE_POST to OFF (for example by using -DINLINE_POST=OFF)

Any comments, suggestions?

DusanJovic-NOAA avatar Oct 26 '22 17:10 DusanJovic-NOAA

@DusanJovic-NOAA If we build w/ inline post ON, the tests (e.g. cpld_control_p8) can still specify WRITE_DOPOST=.false.?

DeniseWorthen avatar Oct 26 '22 17:10 DeniseWorthen

@DusanJovic-NOAA If we build w/ inline post ON, the tests (e.g. cpld_control_p8) can still specify WRITE_DOPOST=.false.?

Yes. WRITE_DOPOST=.false. is run-time option to turn off inline post.

DusanJovic-NOAA avatar Oct 26 '22 18:10 DusanJovic-NOAA