clarin-dspace icon indicating copy to clipboard operation
clarin-dspace copied to clipboard
verified publisher icon ufal

Test handles

Open kosarko opened this issue 9 months ago • 17 comments

  • [x] pid per community configuration
  • [x] handle resolution
    • [x] via handle server
      • [x] https://github.com/dataquest-dev/DSpace/pull/897
    • [ ] Accept application/x-cmdi+xml
      • [x] describe the nginx setup - https://github.com/ufal/clarin-dspace/wiki/NewInstallation#cmdi-data-for-machines
    • [ ] @format=cmdi -> https://github.com/dataquest-dev/DSpace/pull/913
      • [x] describe the nginx setup - https://github.com/ufal/clarin-dspace/wiki/NewInstallation#cmdi-data-for-machines
  • [ ] shortref
    • [ ] https://github.com/dataquest-dev/DSpace/issues/914
    • [ ] #1194
    • [x] describe the nginx setup - when updating the current proxy setup, use: 
      GET
/api/services/handles/magic

POST/PUT
/api/services/handles
  • [ ] handle management
    • [ ] manage local handles (ie. those in handle table)
    • [ ] manage external handles (ie. those provided by epic) -> https://github.com/dataquest-dev/dspace-angular/issues/470#issuecomment-2402130503

kosarko avatar Mar 12 '25 08:03 kosarko

as of now:

  • pid per community assignment is not working (reported)
  • for resolution to work correctly we might need handle.plugin.checknameauthority=false -> https://github.com/dataquest-dev/DSpace/pull/897

kosarko avatar Mar 12 '25 08:03 kosarko

new item with live lrt credentials:

2025-03-21 13:44:57,019 http-nio-8080-exec-3 ERROR 124d4432-f2d7-4d1d-b787-069f7be398ed ed786dc5-2f66-4d7d-a05e-3e6e82a45329 org.dspace.app.rest.exception.DSpaceApiExceptionControllerAdvice @ An exception has occurred (status:500)
java.lang.NullPointerException: null
at org.dspace.api.DSpaceApi.handle_HandleManager_registerFinalHandleURL(DSpaceApi.java:100) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.handle.HandleServiceImpl.createId(HandleServiceImpl.java:425) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.handle.HandleServiceImpl.createHandle(HandleServiceImpl.java:156) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.identifier.ClarinVersionedHandleIdentifierProvider.createNewIdentifier(ClarinVersionedHandleIdentifierProvider.java:349) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.identifier.ClarinVersionedHandleIdentifierProvider.mint(ClarinVersionedHandleIdentifierProvider.java:273) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.identifier.ClarinVersionedHandleIdentifierProvider.register(ClarinVersionedHandleIdentifierProvider.java:94) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.identifier.IdentifierServiceImpl.register(IdentifierServiceImpl.java:193) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.content.WorkspaceItemServiceImpl.create(WorkspaceItemServiceImpl.java:190) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.content.WorkspaceItemServiceImpl.create(WorkspaceItemServiceImpl.java:101) ~[dspace-api-7.6.1.jar:7.6.1]
at org.dspace.app.rest.submit.SubmissionService.createWorkspaceItem(SubmissionService.java:146) ~[classes/:7.6.1]
at org.dspace.app.rest.repository.WorkspaceItemRestRepository.createAndReturn(WorkspaceItemRestRepository.java:206) ~[classes/:7.6.1]

@milanmajchrak nemelo by https://github.com/dataquest-dev/DSpace/blob/ec96cb48fac6f037cb37d822af12dca513682f68/dspace-api/src/main/java/org/dspace/api/DSpaceApi.java#L99 byt dspace.server.url?

@milanmajchrak @vidiecan vidim nekde ve v7, jestli to neco udelalo u toho epic providera? Ve v5 mam ten external handle management, kde to teda najdu s tou dummy adresou, co ve v7? Nebo jsme se nekde dohodli, ze to neni?

Image

kosarko avatar Mar 21 '25 13:03 kosarko

@kosarko

  1. Máš pravdu, zmeníme: https://github.com/dataquest-dev/DSpace/issues/902
  2. Ako admin v manage handles to nie je vidno? Pripadne sa to da pozrieť aj v DB, myslím, že tabuľka handle.
  3. Žial v manage handles som našiel zopár UI issues, ktoré pravdepodobne nastali pri prechode na novšiu verziu, pridávam aj toto do testov:
  • https://github.com/dataquest-dev/dspace-angular/issues/817
  • https://github.com/dataquest-dev/dspace-angular/issues/818

Všetky tieto veci by mali byť fixnute rýchlo.

milanmajchrak avatar Mar 21 '25 13:03 milanmajchrak

@milanmajchrak

Image

  1. je pohled do handle tabulky
  2. je vysledek 3rd party api callu - komunikace s epic api

On ve v7 kvuli te chybe item vubec nevznike. Ale jeden z tech callu do EPICu dobehne a IDcko/handle dostane pro dummy url.

kosarko avatar Mar 21 '25 14:03 kosarko

@kosarko External handle admin tab sme odložili tu: https://github.com/dataquest-dev/dspace-angular/issues/470#issuecomment-2402130503

Čo sa týka erroru s dspace.url, opravíme to, ale ak to bráni testovaniu, tak by si mohol vytvoriť dočasnú cfg property dspace.url do local.cfg alebo dspace.cfg.

milanmajchrak avatar Mar 21 '25 14:03 milanmajchrak

Čo sa týka erroru s dspace.url, opravíme to, ale ak to bráni testovaniu, tak by si mohol vytvoriť dočasnú cfg property dspace.url do local.cfg alebo dspace.cfg.

@milanmajchrak k otestovani asi dobry (dostal jsem se dal). Akorat nemuzeme pouzit dspace.server.url, melo by tam byt neco "na frontendu". V podstate registrujes URL, na kterou uzivatel prijde, kdyz pouzije dany handle. Takze kdyz tam budeme mit dspace.server.url, tak z toho hdl.handle.net/xyz/123 ho to presmeruje na rest api a to nechceme.

kosarko avatar Mar 25 '25 09:03 kosarko

@milanmajchrak muzes mi pripomenout, proc handle server neni ve vlastnim containeru? To melo nejaky funkcni duvody?

kosarko avatar Mar 25 '25 09:03 kosarko

@milanmajchrak Sloupce dead a dead_since by se mely migrovat nebo ne?

kosarko avatar Apr 03 '25 13:04 kosarko

@milanmajchrak Sloupce dead a dead_since by se mely migrovat nebo ne?

Som prekvapený, že nevidím žiadne hodnoty v DB. Vyzerá to, že nie sú zmigrované. Je to showstopper?

milanmajchrak avatar Apr 03 '25 13:04 milanmajchrak

@milanmajchrak kdyz to nezmigrujeme ted, jaky mame moznosti do budoucna? Doplnit to nekdy/nejak za behu? Nebo to olabelovat jako dead/dead_since na novo?

kosarko avatar Apr 03 '25 14:04 kosarko

@milanmajchrak kdyz to nezmigrujeme ted, jaky mame moznosti do budoucna? Doplnit to nekdy/nejak za behu? Nebo to olabelovat jako dead/dead_since na novo?

Podľa mňa handles môžeme potom upraviť cez REST API pomocou Pythonu.

milanmajchrak avatar Apr 03 '25 15:04 milanmajchrak

@milanmajchrak ad EPIC handles a application/x-cmdi+xml resp @format=cmdi - potrebujeme tu url, co posleme do epicu udelat stejne jako ty lokalni handles, tj aby v url byl handle. Jinak https://github.com/ufal/clarin-dspace/wiki/NewInstallation#cmdi-data-for-machines nebude fungovat. Teda prijde mi lepsi sahat do toho DSpaceApi nez do CMDIRestControlleru? Nebo vidis jinou moznost? Tohle mi teda uniklo 🤦‍♂️

kosarko avatar Apr 10 '25 13:04 kosarko

@milanmajchrak ad EPIC handles a application/x-cmdi+xml resp @format=cmdi - potrebujeme tu url, co posleme do epicu udelat stejne jako ty lokalni handles, tj aby v url byl handle. Jinak https://github.com/ufal/clarin-dspace/wiki/NewInstallation#cmdi-data-for-machines nebude fungovat. Teda prijde mi lepsi sahat do toho DSpaceApi nez do CMDIRestControlleru? Nebo vidis jinou moznost? Tohle mi teda uniklo 🤦‍♂️

Len pre ujasnenie bavíme sa o tomto riadku ano: https://github.com/dataquest-dev/DSpace/blob/dtq-dev/dspace-api/src/main/java/org/dspace/api/DSpaceApi.java#L129 Riešenie je, aby sa tam použil handle takto <BE_URL> + /handle/ + <ITEMS_HANDLE> Tiež mi pride lepšie opraviť to v DSpaceAPI.

milanmajchrak avatar Apr 11 '25 07:04 milanmajchrak

Len pre ujasnenie bavíme sa o tomto riadku ano: https://github.com/dataquest-dev/DSpace/blob/dtq-dev/dspace-api/src/main/java/org/dspace/api/DSpaceApi.java#L129 Riešenie je, aby sa tam použil handle takto <BE_URL> + /handle/ + <ITEMS_HANDLE> Tiež mi pride lepšie opraviť to v DSpaceAPI.

ano 👍

kosarko avatar Apr 14 '25 07:04 kosarko

I also found few issues related to "Manage Handles" UI: https://github.com/ufal/clarin-dspace/issues/1216

kuchtiak-ufal avatar Jun 04 '25 15:06 kuchtiak-ufal

The backend part for External (ePIC) Handle UI is here: https://github.com/ufal/clarin-dspace/issues/1217

kuchtiak-ufal avatar Jun 05 '25 12:06 kuchtiak-ufal

Also I found some UI issues related to Manage Handles. These are described here: https://github.com/ufal/clarin-dspace/issues/1216

kuchtiak-ufal avatar Jun 05 '25 12:06 kuchtiak-ufal