clarin-dspace icon indicating copy to clipboard operation
clarin-dspace copied to clipboard

Published 20 hours ago • verified publisher icon ufal

features after 2020.1

Open kosarko opened this issue 10 months ago • 3 comments

  • [ ] shortref:

    • [ ] blacklists, whitelist (url validation) (PRIO: shortref should work)

  • [ ] submission:

    • [ ] type bind on various types (PRIO: status quo)

      • see e.g. https://github.com/ufal/clarin-dspace/blob/clarin/dspace/config/input-forms.xml#L570 and https://github.com/ufal/clarin-dspace/blob/clarin/dspace/config/input-forms.xml#L232

    • [ ] 2 new submission workflows in input-forms (PRIO: status quo)

      • [ ] edm types (PRIO: status quo)
      • [ ] new vocabulary values (PRIO: status quo)
      • [ ] force select dc.type if only one possible value (PRIO: nice to have)
      • [ ] regexp fix for size (PRIO: status quo)
      • [ ] dc.type picker ("no-thumbs" feature) (PRIO: need to render all below; imo don't need the images if it makes things easier...)
        • atm we have <input-type value-pairs-name="common_types">dropdown</input-type><input-type>onebox</input-type><input-type value-pairs-name="teaching_materials">dropdown</input-type>
      • [ ] autocompletes
        • on normal fields
        • on complex fields
        • languages (search in name, fill in iso code)
        • replaces/replaced by (handle+title; search by handle or title, fill in handle;https://github.com/ufal/clarin-dspace/pull/729/commits/471fb5bd1dec92c85f5e7774662f904d64a1a49c)
        • in theory you can add a query in input-forms cf. https://github.com/ufal/clarin-dspace/commit/58e8e3a553ae64b1eb5c6b218ae50f452070fba0 (PRIO: LOW)

    • [ ] openaire feeds (PRIO: if the current api queries all the funders available in openaire; no need to make the set smaller (to just https://github.com/ufal/clarin-dspace/blob/8a6ba5c98547942d7115b74cf4978e0b29ca50e4/dspace/config/modules/openaire.cfg#L3)

    • [ ] ShowInfoStep - message as a first step (PRIO: LOW)

    • [ ] DescribeStep - hint “english only” (PRIO: LOW)

  • [ ] CLI:

    • [ ] ItemImportReplacingMetadata (see https://github.com/ufal/clarin-dspace/pull/922) (PRIO: needed)
    • [ ] runnables (PRIO: not need in new deployments; for upgrades, depends on the procedure) (https://github.com/ufal/clarin-dspace/tree/clarin/dspace-api/src/main/java/cz/cuni/mff/ufal/dspace/runnable) especially: - copy ms size - CheckLicenses (see https://github.com/ufal/clarin-dspace/pull/1062 for how It's run and other details)

  • [ ] curation

    • [ ] MetadataQAChecker (PRIO: needed) - [ ] expected types configurable - [ ] items with files has all rights metadata - [ ] iso639-3 checking

  • [ ] OAI:

    • [ ] col/com filter in oai (don’t expose certain col/com in oai results)
    • [ ] oaiindexevent consumer (and cli) → index as anonymous (see https://github.com/ufal/clarin-dspace/pull/996)
    • [ ] elg crosswalk
      • [ ] langUtil with real iso 693 data, get shortest lang id
    • [ ] metashare update
    • [ ] datacite_openaire update
    • [ ] formats and filter in xoai.xml

  • [ ] item-view:

    • [ ] google dataset search (PRIO: needed)
    • [ ] download from cli info (PRIO: nice to have)
    • [ ] mediaType, shows next to any type (PRIO: status quo)
    • [ ] abbreviated author listing (etal...) (PRIO: needed)
    • [ ] configurable refbox (uses format defined in md) (PRIO: needed)
    • [ ] thumbnail and videotag preview (https://github.com/ufal/clarin-dspace/pull/1004) (PRIO: needed)
    • [ ] previews with limited size (PRIO: depends on the previews implementation)
    • [ ] item-view links use discover, not browse (PRIO: status quo)
    • [ ] #1110
    • [ ] new featured service (TeiTok) (PRIO: needs to show the metadata; editing can be done via edit item)

  • [ ] Licenses:

    • [ ] issue with anonymous confirmation (https://github.com/ufal/clarin-dspace/pull/1062) (PRIO: should not allow anonymous users except when allow anonymous...)
    • [ ] seznam license (PRIO: needed)
      • [ ] translatable text not just link in confirmation (PRIO: needed)

        trik je https://github.com/ufal/clarin-dspace/pull/1068/commits/06dac68f6c2eb5fcdada1c46e46ee10710966b1c#diff-06a9b3a5cc54ccb1654abfdc343ef91cd1c4ef8e6e537494e999aa78de62141cR166 - license url se pouzije jako klic, a pokud danej klic v katalogu (mezi prekladama) neni, pouzije (skoro) prazdnej retezec s mezerou - zbytek toho commitu je presvedcovani dspacu, aby to proslo tady je ceskej text licence: https://github.com/ufal/clarin-dspace/pull/1068/commits/55acf1252e033c3292b524f9e277869cdc5de166#diff-7038a53c9d4b03300c3bff8b4aca10946dfcf1bd84e588586bc36b8884b23824R3310 staticka stranka bere text taky z prekladovyho katalogu: https://github.com/ufal/clarin-dspace/pull/1068/commits/55acf1252e033c3292b524f9e277869cdc5de166#diff-2efd5de166b8f91e3934f42a1f6a7c42c72870d1cae62c6f25df52fc0be1ff5aR3 anglickej preklad je pridanej az v https://github.com/ufal/clarin-dspace/commit/a68f67d8a602c6262b976e94ebfa83df1ca2fd2a

      • [ ] extra license field (ACA_ORG_NAME_AND_SEAT) (PRIO: needed)
      • [ ] monthly download reports (PRIO: needed)
    • [ ] other new licenses (for lindat repo sync static pages; update urls?)

  • [ ] search - [ ] new facets/filters, hierarchical facets, (https://github.com/ufal/clarin-dspace/commits/clarin/dspace/config/spring/api/discovery.xml)

  • [ ] configurable navigation links (deposit/cite/faq/etc.) (PRIO: ATM not needed, use footer)

  • [ ] piwik - [ ] reports and mail queue (PRIO: depends if we have reports, and mail rate limiting....)

  • [ ] db inits that work in ci (https://github.com/ufal/clarin-dspace/commits/clarin/utilities/utilities.sql)

kosarko avatar Apr 05 '24 12:04 kosarko

@kosarko I processed all features - Created issue/Done/Question Please can you answer every question? Thank you. Question start with dq: Q -

  • [ ] shortref:

    • [ ] blacklists, whitelist (url validation) (PRIO: shortref should work)
    • dq: Implemented, but not tested: https://github.com/dataquest-dev/DSpace/blob/dtq-dev/dspace/config/clarin-dspace.cfg#L51
    • dq: Issue for creating tests: https://github.com/dataquest-dev/DSpace/issues/575

  • [ ] submission:

    • [ ] type bind on various types (PRIO: status quo)

      • see e.g. https://github.com/ufal/clarin-dspace/blob/clarin/dspace/config/input-forms.xml#L570 and https://github.com/ufal/clarin-dspace/blob/clarin/dspace/config/input-forms.xml#L232

    • dq: https://github.com/dataquest-dev/DSpace/issues/576

    • [ ] 2 new submission workflows in input-forms (PRIO: status quo)

    • dq: https://github.com/dataquest-dev/DSpace/issues/517

      • [ ] edm types (PRIO: status quo)
      • dq: Done: https://github.com/dataquest-dev/DSpace/issues/550
      • [ ] new vocabulary values (PRIO: status quo)
      • dq: Q - which vocabulary values?
      • [ ] force select dc.type if only one possible value (PRIO: nice to have)
      • dq: https://github.com/dataquest-dev/DSpace/issues/577
      • [ ] regexp fix for size (PRIO: status quo)
      • dq: Q - please more info, how it should looks like?
      • [ ] dc.type picker ("no-thumbs" feature) (PRIO: need to render all below; imo don't need the images if it makes things easier...)
        • atm we have <input-type value-pairs-name="common_types">dropdown</input-type><input-type>onebox</input-type><input-type value-pairs-name="teaching_materials">dropdown</input-type>
      • dq: https://github.com/dataquest-dev/dspace-angular/issues/464
      • [ ] autocompletes
        • on normal fields
        • dq: Done
        • on complex fields
        • dq: Done for Contact Person and Funding (including OpenAIRE) - is it sufficient?
        • languages (search in name, fill in iso code)
        • dq: https://github.com/dataquest-dev/DSpace/issues/580
        • replaces/replaced by (handle+title; search by handle or title, fill in handle;https://github.com/ufal/clarin-dspace/pull/729/commits/471fb5bd1dec92c85f5e7774662f904d64a1a49c)
        • dq: https://github.com/dataquest-dev/DSpace/issues/581
        • in theory you can add a query in input-forms cf. https://github.com/ufal/clarin-dspace/commit/58e8e3a553ae64b1eb5c6b218ae50f452070fba0 (PRIO: LOW) - dq: https://github.com/dataquest-dev/DSpace/issues/579

    • [ ] openaire feeds (PRIO: if the current api queries all the funders available in openaire; no need to make the set smaller (to just https://github.com/ufal/clarin-dspace/blob/8a6ba5c98547942d7115b74cf4978e0b29ca50e4/dspace/config/modules/openaire.cfg#L3)

    • dq: Confirm: https://github.com/dataquest-dev/DSpace/issues/578

    • [ ] ShowInfoStep - message as a first step (PRIO: LOW)

    • dq: https://github.com/dataquest-dev/DSpace/issues/520

    • [ ] DescribeStep - hint “english only” (PRIO: LOW)

    • dq: https://github.com/dataquest-dev/DSpace/issues/582

  • [ ] CLI:

    • [ ] ItemImportReplacingMetadata (see https://github.com/ufal/clarin-dspace/pull/922) (PRIO: needed)
    • dq: https://github.com/dataquest-dev/DSpace/issues/583
    • [ ] runnables (PRIO: not need in new deployments; for upgrades, depends on the procedure) (https://github.com/ufal/clarin-dspace/tree/clarin/dspace-api/src/main/java/cz/cuni/mff/ufal/dspace/runnable) especially: - copy ms size - CheckLicenses (see https://github.com/ufal/clarin-dspace/pull/1062 for how It's run and other details)
    • dq: https://github.com/dataquest-dev/DSpace/issues/584

  • [ ] curation

    • [ ] MetadataQAChecker (PRIO: needed) - [ ] expected types configurable - [ ] items with files has all rights metadata - [ ] iso639-3 checking

  • dq: https://github.com/dataquest-dev/DSpace/issues/513

  • [ ] OAI:

    • [ ] col/com filter in oai (don’t expose certain col/com in oai results)
    • dq: Q - some example?
    • [ ] oaiindexevent consumer (and cli) → index as anonymous (see https://github.com/ufal/clarin-dspace/pull/996)
    • dq: https://github.com/dataquest-dev/DSpace/issues/585
    • [ ] elg crosswalk
      • [ ] langUtil with real iso 693 data, get shortest lang id
    • dq: https://github.com/dataquest-dev/DSpace/issues/586
    • [ ] metashare update
    • dq: Q - Do you mean update of crosswalk?
    • [ ] datacite_openaire update
    • dq: Q - Do you mean update of crosswalk?
    • [ ] formats and filter in xoai.xml
    • dq: Q - Some example pls

  • [ ] item-view:

    • [ ] google dataset search (PRIO: needed)
    • dq: https://github.com/dataquest-dev/dspace-angular/issues/558
    • [ ] download from cli info (PRIO: nice to have)
    • dq: Done, but it is disabled I guess because of disabled previews
    • [ ] mediaType, shows next to any type (PRIO: status quo)
    • dq: Done
    • [ ] abbreviated author listing (etal...) (PRIO: needed)
    • dq: Done
    • [ ] configurable refbox (uses format defined in md) (PRIO: needed)
    • dq: https://github.com/dataquest-dev/dspace-angular/issues/480
    • [ ] thumbnail and videotag preview (https://github.com/ufal/clarin-dspace/pull/1004) (PRIO: needed)
    • dq: https://github.com/dataquest-dev/dspace-angular/issues/372
    • [ ] previews with limited size (PRIO: depends on the previews implementation)
    • dq: Done, but preview is disabled because of S3
    • [ ] item-view links use discover, not browse (PRIO: status quo)
    • dq: Done
    • [ ] date issued formatted (incl approximateDate) (PRIO: needed)
    • dq: Done
    • [ ] new featured service (TeiTok) (PRIO: needs to show the metadata; editing can be done via edit item)
    • dq: TeiTok is Done, but editing is possible only by updating Item's metadata, https://github.com/dataquest-dev/dspace-angular/issues/475

  • [ ] Licenses:

    • [ ] issue with anonymous confirmation (https://github.com/ufal/clarin-dspace/pull/1062) (PRIO: should not allow anonymous users except when allow anonymous...)
    • dq: https://github.com/dataquest-dev/DSpace/issues/588
    • [ ] seznam license (PRIO: needed)
      • [ ] translatable text not just link in confirmation (PRIO: needed)

        trik je https://github.com/ufal/clarin-dspace/pull/1068/commits/06dac68f6c2eb5fcdada1c46e46ee10710966b1c#diff-06a9b3a5cc54ccb1654abfdc343ef91cd1c4ef8e6e537494e999aa78de62141cR166 - license url se pouzije jako klic, a pokud danej klic v katalogu (mezi prekladama) neni, pouzije (skoro) prazdnej retezec s mezerou - zbytek toho commitu je presvedcovani dspacu, aby to proslo tady je ceskej text licence: https://github.com/ufal/clarin-dspace/pull/1068/commits/55acf1252e033c3292b524f9e277869cdc5de166#diff-7038a53c9d4b03300c3bff8b4aca10946dfcf1bd84e588586bc36b8884b23824R3310 staticka stranka bere text taky z prekladovyho katalogu: https://github.com/ufal/clarin-dspace/pull/1068/commits/55acf1252e033c3292b524f9e277869cdc5de166#diff-2efd5de166b8f91e3934f42a1f6a7c42c72870d1cae62c6f25df52fc0be1ff5aR3 anglickej preklad je pridanej az v https://github.com/ufal/clarin-dspace/commit/a68f67d8a602c6262b976e94ebfa83df1ca2fd2a

      • dq: https://github.com/dataquest-dev/dspace-angular/issues/510
      • [ ] extra license field (ACA_ORG_NAME_AND_SEAT) (PRIO: needed)
      • dq: https://github.com/dataquest-dev/DSpace/issues/589
      • [ ] monthly download reports (PRIO: needed)
      • dq: https://github.com/dataquest-dev/DSpace/issues/591
    • [ ] other new licenses (for lindat repo sync static pages; update urls?)
    • dq: Done: https://github.com/dataquest-dev/dspace-angular/issues/559
    • dq: Q - are there more static license pages?

  • [ ] search - [ ] new facets/filters, hierarchical facets, (https://github.com/ufal/clarin-dspace/commits/clarin/dspace/config/spring/api/discovery.xml) - dq: https://github.com/dataquest-dev/DSpace/issues/531 - dq: https://github.com/dataquest-dev/DSpace/issues/590 Q - why is is disabled?

  • [ ] configurable navigation links (deposit/cite/faq/etc.) (PRIO: ATM not needed, use footer)

  • dq: https://github.com/dataquest-dev/dspace-angular/issues/560

  • [ ] piwik - [ ] reports and mail queue (PRIO: depends if we have reports, and mail rate limiting....) - dq: https://github.com/dataquest-dev/DSpace/issues/511

  • [ ] db inits that work in ci (https://github.com/ufal/clarin-dspace/commits/clarin/utilities/utilities.sql)

  • dq: https://github.com/dataquest-dev/DSpace/issues/592

milanmajchrak avatar Apr 08 '24 08:04 milanmajchrak

@milanmajchrak answers below; sorry for mostly referring you to use git log, but that's the most precise capture of the changes...

new vocabulary values (PRIO: status quo) dq: Q - which vocabulary values?

git clone https://github.com/ufal/clarin-dspace
git log ^2020.01 ^dspace-5.11 origin/clarin-dev -p dspace/config/input-forms.xml

and search for changes close to "pairs" or "pair"

regexp fix for size (PRIO: status quo) dq: Q - please more info, how it should looks like?

https://github.com/ufal/clarin-dspace/pull/987

col/com filter in oai (don’t expose certain col/com in oai results) dq: Q - some example?

ebe9829

metashare update dq: Q - Do you mean update of crosswalk?

yes,

git log -p ^2020.01 ^dspace-5.11 origin/clarin-dev dspace/config/crosswalks/oai/metadataFormats/metasharev2.xsl

datacite_openaire update dq: Q - Do you mean update of crosswalk? yes

git log -p ^2020.01 ^dspace-5.11 origin/clarin-dev dspace/config/crosswalks/oai/metadataFormats/datacite_openaire.xsl

formats and filter in xoai.xml dq: Q - Some example pls

git log -p ^2020.01 ^dspace-5.11 origin/clarin-dev dspace/config/crosswalks/oai/xoai.xml

dq: Q - are there more static license pages?

With

git log --name-status ^2020.01 ^dspace-5.11 origin/clarin-dev dspace-xmlui/src/main/webapp/themes/UFAL/lib/html/

you can see the last license ud 2.13 was added in Nov 2023, not sure if all has been migrated...

kosarko avatar Apr 08 '24 15:04 kosarko

new vocabulary values (PRIO: status quo)

  • dq: https://github.com/dataquest-dev/DSpace/issues/616

regexp fix for size (PRIO: status quo)

  • dq: https://github.com/dataquest-dev/DSpace/issues/617

col/com filter in oai (don’t expose certain col/com in oai results)

  • dq: https://github.com/dataquest-dev/DSpace/issues/618

metashare update dq: Done

datacite_openaire update dq: Done

formats and filter in xoai.xml

  • dq: https://github.com/dataquest-dev/DSpace/issues/619

other new licenses (for lindat repo sync static pages; update urls?)

  • dq: https://github.com/dataquest-dev/dspace-angular/issues/589

milanmajchrak avatar Apr 10 '24 13:04 milanmajchrak