Licenses

[kosarko]

A catchall issue tracking various problems with licenses. Feel free to convert them into individual issues as needed. Some might just need confirmation that that's the intended state...

• [ ] license administration
  • [ ] What is the sort order?
  • [x] count/pagination is broken
  • [ ] search not working -> https://github.com/ufal/clarin-dspace/issues/1055#issuecomment-1559257517
• [ ] licenses in submission
  • [x] the old license dropdown shows also labels
  • [ ] the collections have default dspace license (document this needs to be set up) 2️⃣
• [ ] browser console on item-view page shows warning 2️⃣ "dspace-rest-response-parsing.service.ts:155 The response for 'https://ufal-point-dev.ufal.hide.ms.mff.cuni.cz/repository/api/core/clarinlicenses/search/byName?name=Creative Commons - Attribution-NonCommercial-ShareAlike 4.0 International (CC BY-NC-SA 4.0)' has the self link 'https://ufal-point-dev.ufal.hide.ms.mff.cuni.cz/repository/api/core/clarinlicenses/search/byName?name=Creative%20Commons%20-%20Attribution-NonCommercial-ShareAlike%204.0%20International%20(CC%20BY-NC-SA%204.0)'. These don't match. This could mean there's an issue with the REST endpoint"
• [ ] on the db level
  • license_definition
    • ~user_registration_id (but these are null)~
    • label_id all is null 2️⃣
    • created_on all is null 2️⃣
• [ ] ask once/always and other license imposed restrictions ~not tested yet.~
  • [ ] 403 instead of a form https://github.com/ufal/clarin-dspace/issues/1055#issuecomment-1559429330

2️⃣ were tested on 2023-05-23 and still were an issue

[kosarko]

count/pagination works in f64b24dbc

[kosarko]

There is a search field in license administration which is not working there is:

{
    "timestamp": "2023-05-23T12:47:22.631+00:00",
    "status": 500,
    "error": "Internal Server Error",
    "message": "An exception has occurred",
    "path": "/repository/api/core/clarinlicenses/search/byNameLike"
}

and maybe this:

2023-05-23 14:46:51,477 INFO  328be8e7-b6a1-4b20-8bbd-e34515691a87 5ca670ec-5b07-4536-9229-36bdf84f9373 org.dspace.app.rest.utils.DSpaceAPIRequestLoggingFilter @ Before request [GET /repository/api/core/clarinlicenses/search/byNameLike] originated from /licenses?cLicense.page=6#p-cLicense
2023-05-23 14:46:51,518 ERROR 328be8e7-b6a1-4b20-8bbd-e34515691a87 5ca670ec-5b07-4536-9229-36bdf84f9373 org.dspace.app.rest.exception.DSpaceApiExceptionControllerAdvice @ An exception has occurred (status:500)
org.dspace.app.rest.exception.PaginationException: null
        at org.dspace.app.rest.utils.Utils.getPage(Utils.java:148) ~[classes/:7.2.1]
        at org.dspace.app.rest.converter.ConverterService.toRestPage(ConverterService.java:211) ~[classes/:7.2.1]
        at org.dspace.app.rest.repository.ClarinLicenseRestRepository.findByNameLike(ClarinLicenseRestRepository.java:122) ~[classes/:7.2.1]
        at org.dspace.app.rest.repository.ClarinLicenseRestRepository$$FastClassBySpringCGLIB$$2f766ee7.invoke(<generated>) ~[classes/:7.2.1]
        at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) ~[spring-core-5.2.20.RELEASE.jar:5.2.20.RELEASE]
        at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689) ~[spring-aop-5.2.20.RELEASE.jar:5.2.20.RELEASE]
        at org.dspace.app.rest.repository.ClarinLicenseRestRepository$$EnhancerBySpringCGLIB$$fc8044f6.findByNameLike(<generated>) ~[classes/:7.2.1]
        at jdk.internal.reflect.GeneratedMethodAccessor497.invoke(Unknown Source) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
        at org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:282) ~[spring-core-5.2.20.RELEASE.jar:5.2.20.RELEASE]
        at org.dspace.app.rest.utils.RestRepositoryUtils.invokeQueryMethod(RestRepositoryUtils.java:176) ~[classes/:7.2.1]
        at org.dspace.app.rest.utils.RestRepositoryUtils.executeQueryMethod(RestRepositoryUtils.java:159) ~[classes/:7.2.1]
        at org.dspace.app.rest.RestResourceController.executeSearchMethods(RestResourceController.java:999) ~[classes/:7.2.1]
        at jdk.internal.reflect.GeneratedMethodAccessor405.invoke(Unknown Source) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]

[kosarko]

submission license dropdown labels work in https://github.com/ufal/clarin-dspace/commit/f64b24dbcd386cfd6487fbd69c7fe59fef4e5ac2 + https://github.com/dataquest-dev/dspace-angular/commit/15da4564d5

[kosarko]

I get a 403 instead of an agreement form when downloading a file with a restrictive license.

[kosarko]

attempt file download -> license agreement

• with ask always licenses either:

  • ERR_TOO_MANY_REDIRECTS (that is with yarn build:prod) or
  • nothing downloaded end up on home (yarn start:dev)

• no ip in license agreement

  • 'http://api.ipify.org/?format=json'. This request has been blocked; the content must be served over HTTPS.