libskk icon indicating copy to clipboard operation
libskk copied to clipboard

Fix okuri-ari entry dictionary edit

Open buzztaiki opened this issue 4 years ago • 4 comments

It fixes #77

The following seemed to be the cause:

  • candidate.midasi was using the value of state.get_yomi, so this value was ぐぐ*る.
  • candidate.output did not have a okuri-gana, so this value was ググ.

I Extract the code for SelectStateHandler to generate midasi as State.get_midasi. and use it in Context. And also I append state.okuri_rom_kana_converter.output to the output text when okuri is true.

buzztaiki avatar Nov 19 '21 13:11 buzztaiki

Thanks for your approval!

buzztaiki avatar Nov 21 '21 02:11 buzztaiki

CI doesn't seem to be running... :confused:

buzztaiki avatar Nov 21 '21 02:11 buzztaiki

It looks like the setting needs to be migrated since June 2021.

https://docs.travis-ci.com/user/migrate/open-source-repository-migration

buzztaiki avatar Nov 21 '21 02:11 buzztaiki

Yeah, indeed; I've just opened #81.

ueno avatar Nov 21 '21 14:11 ueno