ibus-kkc icon indicating copy to clipboard operation
ibus-kkc copied to clipboard

Migrate IBusConfig to GSettings

Open fujiwarat opened this issue 6 years ago • 15 comments

Fixes issue#8.

fujiwarat avatar Nov 01 '18 08:11 fujiwarat

I updated the patch.

fujiwarat avatar Nov 13 '18 11:11 fujiwarat

I updated the patch.

fujiwarat avatar Nov 19 '18 11:11 fujiwarat

I updated the patch.

fujiwarat avatar Nov 20 '18 13:11 fujiwarat

I updated the patch.

fujiwarat avatar Nov 27 '18 09:11 fujiwarat

Are there any chances to integrate the patch?

fujiwarat avatar Dec 10 '18 06:12 fujiwarat

Are there any chances to integrate the patch?

fujiwarat avatar Dec 21 '18 11:12 fujiwarat

Not at this code quality. I only pointed the fundamental issues, and there are still several weird things in the code: no documentation in the gschema, abusive uses of binding in setup.vala, strange naming of functions, etc. I guess I would need to rewrite it before merging.

ueno avatar Dec 23 '18 07:12 ueno

When do you finish it? I don't mind that kind of the quality of this module but hope to get the rough schedule. Probably I think this would be a last one I should track.

fujiwarat avatar Dec 26 '18 16:12 fujiwarat

Actually my original plan was the next RHEL but it would not be on time. But it would be great if this could be fixed this asap.

fujiwarat avatar Dec 26 '18 17:12 fujiwarat

I don't mind that kind of the quality of this module

What you think doesn't matter, because this module is not yours. I just can't merge your change, as it looks stupidly ugly from my point of view.

ueno avatar Dec 27 '18 06:12 ueno

So when do you finish it? I just created the patch since you don't do.

fujiwarat avatar Dec 27 '18 10:12 fujiwarat

If you think this arrogant tone moves things forward, I doubt you have essential skills in communication.

ueno avatar Dec 29 '18 13:12 ueno

I really don't understand what you pointed out on me. I said the migration is important and asked you when you finish the task. So when do you finish it?

fujiwarat avatar Jan 01 '19 10:01 fujiwarat

Do you have any chances to create the patch?

no documentation in the gschema, abusive uses of binding in setup.vala, strange naming of functions, etc.

If you would clarify the changes with detail, I might be able to contribute this patch.

fujiwarat avatar May 07 '19 05:05 fujiwarat

ping

fujiwarat avatar Jul 10 '19 06:07 fujiwarat