feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Leverage DraggableScrollabeController Once It's Available

Open caseycrogers opened this issue 2 years ago • 5 comments

When #149 goes in, developers using the expandable bottom sheet feature will have to use FeedbackSheetDragHandle in the feedback sheet builder to provide a visual drag handle for users.

This is pretty clunky, but the only way to do it because the drag handle needs to be placed as a fixed header on top of their scrollable widget in order for users to be able to click and drag on it to drag the sheet. Once DraggableScrollableSheet supports programmatic control in production (see: https://github.com/flutter/flutter/pull/92440) we can pull the drag handle out of the builder so that developers don't have to provide it.

Additionally, the feedback_widget uses a value notifier internally to manage sheet related animations. This can also be replaced by referencing the controller directly assuming the controller is made a ChangeNotifier.

caseycrogers avatar Dec 29 '21 16:12 caseycrogers

Any updates to this?

kamami avatar Jan 25 '22 11:01 kamami

DraggableScrollabeController will probably be included in the next Flutter version. There's no date for that yet, but I expect it to be around February or March.

ueman avatar Jan 25 '22 11:01 ueman

Is already on master and fully functional?

kamami avatar Jan 25 '22 11:01 kamami

I'm not sure what you're referring to. flutter/flutter#92440 is already on master and fully functional. This library however doesn't yet support it.

ueman avatar Jan 25 '22 11:01 ueman

Thanks for your response! I missed that this is a separate package...

kamami avatar Jan 25 '22 12:01 kamami

Any updates on this? I need to expand the sheet programatically.

quoc-huynh-cosee avatar Jul 13 '23 11:07 quoc-huynh-cosee

Closed via https://github.com/ueman/feedback/pull/239

ueman avatar Sep 24 '23 09:09 ueman