Dieter Weber comments

Results 225 comments of


                                            Dieter Weber

Bounds check for rectangular ROI

Not reproducible with mouse, just with keyboard with 0.11 development version

Link simulated graphene 4D STEM dataset

Bumping to this release since we now support NPY and it sounds like an easy win.

Be more strict with warnings in CI

@sk1p @matbryan52 is this addressed sufficiently in #1573 or should we keep it open?

Meta issue: Advanced executor

Skimming through the discussion, it seems that most issues are resolved by using the PipelinedExecutor and the Rust-based receiver code in LiberTEM-live? Closing as pretty much completed! :champagne:

GPU and sparse: I/O and performance optimizations

Bumping milestone since performance impact can be large for both sparse data and GPU data, and it is growing in importance.

Constructing GCXS from non-canonical `scipy.sparse.csr_matrix` results in wrong results

> Hello, what exactly do you mean by canonical here? Can this be reproduced without `cupyx` perhaps? It can be reproduced if the data within a row is not sorted...

Constructing GCXS from non-canonical `scipy.sparse.csr_matrix` results in wrong results

See https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.csr_matrix.has_canonical_format.html#scipy.sparse.csr_matrix.has_canonical_format for the definition of "canonical"!

Constructing GCXS from non-canonical `scipy.sparse.csr_matrix` results in wrong results

This code is a compact reproducer without cupy: https://github.com/LiberTEM/sparseconverter/blob/4cfc0ee2ad4c37b07742db8f3643bcbd858a4e85/src/sparseconverter/__init__.py#L154-L183

Test notebook for cells with a semicolon

Btw, feel free to push into this PR if you like!

Deprecate gridmatching and fullmatch

/azp run libertem.libertem-data