Benjamin Uekermann
Benjamin Uekermann
What we need to do as well: document all functions. At least a few lines in front of every function. E.g. what does [this function](https://github.com/precice/fluent-adapter/blob/cd1cd73b8b0db23a38dcfaaa73c532e9d753294a/src/fsi.c#L752) do?
Thanks for posting this. I agree that we should do some error check here. However, I am not too convinced by the flag `do_security_checks`. Actually, I don't see a use...
> For moving time grids everything will be interpolated to the first time grid from the first time window inside the QNWR class instead of using the waveforms inside the...
Now that #1996 is done, we could reformulate this PR using the new "secondary" implementation.
Which config runs into this error? We should probably forbid the config in the first place already.
Yes, we could do better here. Thanks for reporting!
Sounds good to me.
This is no bug to me. It's just that we don't check for such valid, but not meaningful configurations. This is not easy to check. Needs to be a global...
## Use cases I still have some doubts about the use cases. Having a concrete example here would help a lot. > a convergence measure that uses weighted data in...
For further reading, also consider the [master thesis of Peter Vollmer](https://www.ipvs.uni-stuttgart.de/abteilungen/sgs/lehre/studentische_arbeiten/masterarbeiten/peter.vollmer) and the thesis of @floli . Back then, we also tested a variant based on an "MPI server" (I...