update VueNodeViewRenderer

[AndreyChelnokov]

Changes Overview

Removed handleSelectionUpdate as it did nothing useful but constantly calculated the position

Implementation Approach

Testing Done

Yes, I did various tests to make sure nothing would break.

For testing, you can run the repository's development mode and ensure that the ProseMirror-selectednode class and the selected property are set to bypass the remote method.

Verification Steps

Additional Notes

The selectNode and deselectNode methods are called independently of the handleSelectionUpdate method. Furthermore, previously the handleSelectionUpdate method performed position calculations every time, but never called selectNode and deselectNode because the conditions for calling them were not met.

Checklist

• [ ] I have created a changeset for this PR if necessary.
• [+] My changes do not break the library.
• [ ] I have added tests where applicable.
• [+] I have followed the project guidelines.
• [ ] I have fixed any lint issues.

Related Issues

https://github.com/ueberdosis/tiptap/issues/6440

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: cfc6f39af798cb4c36d10961f7296513800208fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify[bot]]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	cfc6f39af798cb4c36d10961f7296513800208fb
🔍 Latest deploy log	https://app.netlify.com/projects/tiptap-embed/deploys/684ad8f80046880008e08c38
😎 Deploy Preview	https://deploy-preview-6445--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[pkg-pr-new[bot]]

Open in StackBlitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@6445

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@6445

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@6445

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@6445

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@6445

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@6445

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@6445

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@6445

@tiptap/extension-collaboration-caret

npm i https://pkg.pr.new/@tiptap/extension-collaboration-caret@6445

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@6445

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@6445

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@6445

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@6445

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@6445

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@6445

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@6445

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@6445

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@6445

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@6445

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@6445

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@6445

@tiptap/extension-list

npm i https://pkg.pr.new/@tiptap/extension-list@6445

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@6445

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@6445

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@6445

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@6445

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@6445

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@6445

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@6445

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@6445

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@6445

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@6445

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@6445

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@6445

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@6445

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@6445

@tiptap/extensions

npm i https://pkg.pr.new/@tiptap/extensions@6445

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@6445

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@6445

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@6445

@tiptap/static-renderer

npm i https://pkg.pr.new/@tiptap/static-renderer@6445

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@6445

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@6445

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@6445

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@6445

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@6445

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@6445

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@6445

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@6445

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@6445

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@6445

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@6445

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@6445

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@6445

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@6445

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@6445

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@6445

commit: cfc6f39

[bdbch]

@AndreyChelnokov could you rebase this to the current develop branch as we released V3, deprecating the next branch & would need to update most of our PR's anyway? Thanks a lot!