tiptap icon indicating copy to clipboard operation
tiptap copied to clipboard

fix: don't consider text nodes with blank lines as completely empty

Open rChaoz opened this issue 5 months ago • 3 comments

Changes Overview

Closes #6436

Implementation Approach

Testing Done

Verification Steps

This work well with code blocks. Create an editor with a codeblock and type in some text that contains a blank line, e.g.

abc

123

and call isNodeEmpty() on it. It incorrectly returns true, with this PR it returns false.

Additional Notes

Checklist

  • [x] I have created a changeset for this PR if necessary.
  • [x] My changes do not break the library.
  • [x] I have added tests where applicable.
  • [x] I have followed the project guidelines.
  • [x] I have fixed any lint issues.

Related Issues

rChaoz avatar Jun 11 '25 08:06 rChaoz

🦋 Changeset detected

Latest commit: bf01f376f8f4e1ca3232eeb3b156522a98e341e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 11 '25 08:06 changeset-bot[bot]

Deploy Preview for tiptap-embed ready!

Name Link
Latest commit 9abcc1c6039d30fe3a661d50db8d1cfdee7f4362
Latest deploy log https://app.netlify.com/projects/tiptap-embed/deploys/68493d8824ac2c00086752ec
Deploy Preview https://deploy-preview-6437--tiptap-embed.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 11 '25 08:06 netlify[bot]

Deploy Preview for tiptap-embed ready!

Name Link
Latest commit bf01f376f8f4e1ca3232eeb3b156522a98e341e3
Latest deploy log https://app.netlify.com/projects/tiptap-embed/deploys/684941c100c7ac0008b08949
Deploy Preview https://deploy-preview-6437--tiptap-embed.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 11 '25 08:06 netlify[bot]