tiptap
tiptap copied to clipboard
ueberdosis
Allow default behaviour in stopEvent/ignoreMutation overrides
Changes Overview
In my case, I needed to override stopEvent, but only for a specific case. Otherwise I'd like for it to have a default behaviour. To do this, I'd have to recreate all the checks from default stopEvent in my override. This PR addresses this inconvenience.
Implementation Approach
stopEvent ignores override only if you explicitly return a null. This should minimize a breaking change for existing usages.
Testing Done
Verification Steps
Additional Notes
Checklist
- [ ] I have created a changeset for this PR if necessary.
- [ ] My changes do not break the library.
- [ ] I have added tests where applicable.
- [ ] I have followed the project guidelines.
- [ ] I have fixed any lint issues.
Related Issues
#257
🦋 Changeset detected
Latest commit: 723813b83e21ba409a7463c02c4ddca1be4c06eb
The changes in this PR will be included in the next version bump.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for tiptap-embed failed. Why did it fail? →
| Name | Link |
|---|---|
| Latest commit | 1587216fd763744c3c1da3edc381e39dff302fa6 |
| Latest deploy log | https://app.netlify.com/sites/tiptap-embed/deploys/66d963138020b200085ce28b |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for tiptap-embed ready!
| Name | Link |
|---|---|
| Latest commit | 723813b83e21ba409a7463c02c4ddca1be4c06eb |
| Latest deploy log | https://app.netlify.com/projects/tiptap-embed/deploys/6860a1e0e18d750008240792 |
| Deploy Preview | https://deploy-preview-5590--tiptap-embed.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Sorry - one more thing. Could you rebase this PR into next so we can cherry-pick it down to main/develop? We don't use develop for active dev anymore.
@alexkuz could you rebase this to the current develop branch as we released V3, deprecating the next branch & would need to update most of our PR's anyway? Thanks a lot! I will look into getting this merged afterwards!