tiptap icon indicating copy to clipboard operation
tiptap copied to clipboard

fix(vue-3): provide app global

Open Rirax opened this issue 1 year ago • 2 comments

Changes Overview

In refacto's work to improve rendering performance of vue-3 components we attached appContext to EditorContent but forgot to bind it to the rendered vNode. https://github.com/ueberdosis/tiptap/pull/5206

Implementation Approach

We bind appContext on the rendered vNode

Testing Done

Verification Steps

Additional Notes

Checklist

  • [ ] I have created a changeset for this PR if necessary.
  • [x] My changes do not break the library.
  • [x] I have added tests where applicable.
  • [x] I have followed the project guidelines.
  • [x] I have fixed any lint issues.

Related Issues

https://github.com/ueberdosis/tiptap/issues/5323

Rirax avatar Jul 16 '24 09:07 Rirax

⚠️ No Changeset found

Latest commit: 77246a2986058df266f745ca8672581dbaa22cb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 16 '24 09:07 changeset-bot[bot]

Deploy Preview for tiptap-embed ready!

Name Link
Latest commit 77246a2986058df266f745ca8672581dbaa22cb7
Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6696427b6fd28a000855f84d
Deploy Preview https://deploy-preview-5354--tiptap-embed.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 16 '24 09:07 netlify[bot]