tiptap
tiptap copied to clipboard
VueNodeViewRenderer should return `null` for `contentDOM` for a non-leaf node with no `NodeViewContent`
Please describe your changes
For a non-leaf node with no NodeViewContent
return null
instead of this.dom
, this allows the node view itself to handle rendering the child content, instead of overriding the entire node with its child contents, not allowing to render it at all.
How did you accomplish your changes
I changed a line of code.
How have you tested your changes
In my own project.
How can we verify your changes
Create a node view that has child content
, but no NodeViewContent
.
Remarks
[add any additional remarks here]
Checklist
- [x] The changes are not breaking the editor
- [ ] Added tests where possible
- [x] Followed the guidelines
- [x] Fixed linting issues
Related issues
Fixes #3937
Deploy Preview for tiptap-embed ready!
Name | Link |
---|---|
Latest commit | 015cecf966dea5167cc7f0761841a9c750955b7b |
Latest deploy log | https://app.netlify.com/sites/tiptap-embed/deploys/669e0cb04b68260007bd1957 |
Deploy Preview | https://deploy-preview-3966--tiptap-embed.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
This is also necessary in my use case. I found out about this PR by stopping at the same line in the code that was modified by the OP. If this PR were merged, how could a node view modify its own content? Do you know if there's a Tiptap or ProseMirror API for this?
Why was this closed?
🦋 Changeset detected
Latest commit: 015cecf966dea5167cc7f0761841a9c750955b7b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 54 packages
Name | Type |
---|---|
@tiptap/vue-3 | Patch |
@tiptap/core | Patch |
@tiptap/extension-blockquote | Patch |
@tiptap/extension-bold | Patch |
@tiptap/extension-bubble-menu | Patch |
@tiptap/extension-bullet-list | Patch |
@tiptap/extension-character-count | Patch |
@tiptap/extension-code-block-lowlight | Patch |
@tiptap/extension-code-block | Patch |
@tiptap/extension-code | Patch |
@tiptap/extension-collaboration-cursor | Patch |
@tiptap/extension-collaboration | Patch |
@tiptap/extension-color | Patch |
@tiptap/extension-document | Patch |
@tiptap/extension-dropcursor | Patch |
@tiptap/extension-floating-menu | Patch |
@tiptap/extension-focus | Patch |
@tiptap/extension-font-family | Patch |
@tiptap/extension-gapcursor | Patch |
@tiptap/extension-hard-break | Patch |
@tiptap/extension-heading | Patch |
@tiptap/extension-highlight | Patch |
@tiptap/extension-history | Patch |
@tiptap/extension-horizontal-rule | Patch |
@tiptap/extension-image | Patch |
@tiptap/extension-italic | Patch |
@tiptap/extension-link | Patch |
@tiptap/extension-list-item | Patch |
@tiptap/extension-list-keymap | Patch |
@tiptap/extension-mention | Patch |
@tiptap/extension-ordered-list | Patch |
@tiptap/extension-paragraph | Patch |
@tiptap/extension-placeholder | Patch |
@tiptap/extension-strike | Patch |
@tiptap/extension-subscript | Patch |
@tiptap/extension-superscript | Patch |
@tiptap/extension-table-cell | Patch |
@tiptap/extension-table-header | Patch |
@tiptap/extension-table-row | Patch |
@tiptap/extension-table | Patch |
@tiptap/extension-task-item | Patch |
@tiptap/extension-task-list | Patch |
@tiptap/extension-text-align | Patch |
@tiptap/extension-text-style | Patch |
@tiptap/extension-text | Patch |
@tiptap/extension-typography | Patch |
@tiptap/extension-underline | Patch |
@tiptap/extension-youtube | Patch |
@tiptap/html | Patch |
@tiptap/pm | Patch |
@tiptap/react | Patch |
@tiptap/starter-kit | Patch |
@tiptap/suggestion | Patch |
@tiptap/vue-2 | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR