ueberdosis
SocketId sometimes changes for a websocket connection/user
Description
Sometimes the socketId of a user changes within the context of our logs.
Let it be noted that a new socketId should be generated for every new websocket connection that is coming in.
This is not causing any issues to the best of our knowledge, but it was an interesting observation.
Just wondering if we have any ideas why this could happen?
Steps to reproduce the bug Not reproducible at the moment.
Expected behavior
socketId should not change for a websocket connection.
Screenshot, video, or GIF
In the screenshot, we can see the new user who connected to the document has their socketId attributed to a change event for another user. Websocket key is our own identifier for tracking websocket connections (so we would have expected them to match in comparison to the socketId).
Additional context
We have multiple instances of this socketId flipping in our logs for this case.
hey @ralphiee22, thanks for reporting this! This is weird indeed.
Can you share a few more information about your setup, are you using any extensions? How exactly do you generate the log output? I guess it's during the onChange hook? The server runs only one instance of Hocuspocus?
We are using the redis-extension, and using a modified version of extension-logger which allows us to format the data (but we are not altering the data passed from the hooks).
A snippet of what that looks like below.
I guess it's during the onChange hook?
Not isolated to onChange hook. We log all hooks, but we have seen it in the store hook as well.
We actually run a separate hocuspocus instance per our custom types. In this example, I am confirming it is acting upon the same type (as you can tell by the identifier in the logs).