ueberauth_google icon indicating copy to clipboard operation
ueberauth_google copied to clipboard

Runtime config should be put in config/runtime.exs?

Open kayuapi opened this issue 3 years ago • 1 comments

Hi all,

currently the guide shows that we configure the runtime environment like this: https://github.com/ueberauth/ueberauth_google/blob/master/README.md#installation

Use that if you want to read client ID/secret from the environment variables in the run time:

config :ueberauth, Ueberauth.Strategy.Google.OAuth, client_id: {System, :get_env, ["GOOGLE_CLIENT_ID"]}, client_secret: {System, :get_env, ["GOOGLE_CLIENT_SECRET"]}

Should we put the config in config/runtime.exs like the following:

config :ueberauth, Ueberauth.Strategy.Google.OAuth, client_id: System.get_env("GOOGLE_CLIENT_ID"), client_secret: System.get_env("GOOGLE_CLIENT_SECRET")

kayuapi avatar Nov 09 '21 03:11 kayuapi

PR welcome ❤️

yordis avatar Nov 09 '21 05:11 yordis