ueberauth_google icon indicating copy to clipboard operation
ueberauth_google copied to clipboard

Published 20 hours ago • verified publisher icon ueberauth

Handle client side flow for google auth.

Open rohanpujaris opened this issue 7 years ago • 15 comments

Use ueberauth_google with client side flow, when user just passes token to server.

rohanpujaris avatar Apr 11 '17 16:04 rohanpujaris

Any updates on this? I’m running into issues with my spa + api because of this.

blakedietz avatar Oct 19 '17 05:10 blakedietz

@blakedietz Sorry for the delays, I'll look over things and see where they stand. In the mean time @yordis or @hassox do you have any further questions or concerns?

doomspork avatar Oct 25 '17 18:10 doomspork

@doomspork as long as I don't depends of Plug.Conn because when you use GraphQL/Absinthe I don't have access to such of thing so.

yordis avatar Oct 25 '17 18:10 yordis

@doomspork @yordis Should I proceed with removing %Plug.Conn{} reference on this PR. reference is also present here -> https://github.com/rohanpujaris/ueberauth_google/blob/master/lib/ueberauth/strategy/google.ex#L34

Let me know if we want to remove it from above code as well?

rohanpujaris avatar Nov 29 '17 19:11 rohanpujaris

@rohanpujaris dont worry about it for now.

yordis avatar Nov 29 '17 19:11 yordis

@ueberauth/developers just roll with what we have right now so when we introduce token workflow we go back to all the providers and we take care of the use case

yordis avatar Nov 29 '17 20:11 yordis

@yordis why would we want to remove the Conn ever? If you want to fetch the user without the Conn just call Ueberauth.Strategy.Google.OAuth.get/2 (which is already public) and you're done.

scrogson avatar Nov 30 '17 00:11 scrogson

@scrogson yes but, details like those

  • https://github.com/ueberauth/ueberauth_facebook/blob/3fa42abb3b09e54e606c402944c798ea7f83e669/lib/ueberauth/strategy/facebook.ex#L135
  • https://github.com/ueberauth/ueberauth_facebook/blob/3fa42abb3b09e54e606c402944c798ea7f83e669/lib/ueberauth/strategy/facebook.ex#L138

and returning the same ueberauth data structure back is why I wouldn't do the request myself.

Outside, yes just call the API directly.

yordis avatar Nov 30 '17 02:11 yordis

is it not planned to have this merged?

benonymus avatar Jul 17 '19 15:07 benonymus

@rohanpujaris / @ueberauth/core — where is this PR at? What do we need to do to finish getting this merged? @yordis how does this impact the proposed changes you'd like to make?

doomspork avatar Oct 23 '19 18:10 doomspork

There are multiple ways to implement this, the only issue going for this route is the dependency with Plug.Conn which I guess is fine for now, but people in Absinthe land and other situations where they don't have a Plug.Conn can't use the feature.

yordis avatar Oct 23 '19 19:10 yordis

Can we get this merged?

sergiotapia avatar Jun 14 '21 03:06 sergiotapia

Hi! What is the plan for this PR?

luka-TU avatar Sep 06 '21 08:09 luka-TU

@ueberauth/developers I completely lost track of this, my apologies. Any thoughts?

yordis avatar Jul 08 '22 17:07 yordis

I am no longer working on Elixir and PhoenixFramework. If anybody wants to take this forward, feel free to do so.

rohanpujaris avatar Sep 20 '22 08:09 rohanpujaris