oauth2 icon indicating copy to clipboard operation
oauth2 copied to clipboard

Make Client authentication extensible and support client_secret_jwt

Open ritou opened this issue 3 years ago • 4 comments

Abstract

There are several types of Client authentication defined for use when making a request to the Token Endpoint in OAuth 2.0. These are named "client_secret_basic", "client_secret_post", "client_secret_jwt", etc. in OpenID Connect and RFC8414.

Currently, only Client Credentials supports multiple Client authentications, the others are only "client_secret_basic". This PR supports "client_secret_post" and "client_secret_jwt" for all GrantType. It is also compatible with implementations that already use "request_body(client_secret_post)" for Client Credentials.

Related Specs

ritou avatar Jan 02 '22 10:01 ritou

Absolutely great changes here! I'd love to see them merged.

lukyanov avatar Jan 20 '22 14:01 lukyanov

Hello there! Any plan to merge this soon? 🙏🏼

mustela avatar Sep 13 '22 10:09 mustela

Those functions added, do they need to be public functions, or are they meant to be used only inside the package scope?

This should be a public function of "OAuth2.Client". This will also be needed when developers create new standardized or proprietary strategies.

ritou avatar Dec 05 '22 05:12 ritou

This pull request has been automatically marked as "stale:discard". If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated!.

github-actions[bot] avatar Feb 06 '24 02:02 github-actions[bot]

Closing this pull request after a prolonged period of inactivity. If this issue is still relevant, please ask for this pull request to be reopened. Thank you!

github-actions[bot] avatar Apr 07 '24 02:04 github-actions[bot]