guardian icon indicating copy to clipboard operation
guardian copied to clipboard

Fix deprecation warnings based on 1.14-dev.

Open crova opened this issue 2 years ago • 0 comments

Greetings, how is it going?

As mentioned on this issue there are a few warnings when compiling while using elixir 1.14.

Besides those that were mentioned, when useing Guardian on a module, the following warn would raise:

warning: Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead

This PR address both issues.

Please let me know if I should improve this PR somehow.

Cheers.

crova avatar Aug 10 '22 13:08 crova

I'm also trying to upgrade Elixir v1.14.0-rc.1 and facing the same deprecation warning with Application.get_env/3.

Also mix compile --force --warnings-as-errors is a requirement for me(i.e. CI pipeline). That ties upgrading Elixir to this PR (or a better solution).

gungorkocak avatar Aug 31 '22 09:08 gungorkocak

Related to #704

kevinkirkup avatar Sep 01 '22 22:09 kevinkirkup

💜

yordis avatar Sep 02 '22 02:09 yordis