zartan icon indicating copy to clipboard operation
zartan copied to clipboard

[BUG] Remove custom s3 cdn of auth-js for offical okta cdn urls

Open noinarisak opened this issue 2 years ago • 1 comments

Describe the bug There are collection places in the Jinja template files that reference custom s3 url for now official Okta CDN js libs.

▶ ack cdn-zartan.s3.us-east-2.amazonaws.com/static/js/okta-auth-js.min.js
_admin/templates/admin/index.html
2:<script src="https://cdn-zartan.s3.us-east-2.amazonaws.com/static/js/okta-auth-js.min.js" type="text/javascript"></script>

_streamingservice/templates/streamingservice/device_activate.html
3:    <script src="https://cdn-zartan.s3.us-east-2.amazonaws.com/static/js/okta-auth-js.min.js" type="text/javascript"></script>

_streamingservice/templates/streamingservice/device_complete.html
3:    <script src="https://cdn-zartan.s3.us-east-2.amazonaws.com/static/js/okta-auth-js.min.js" type="text/javascript"></script>

_streamingservice/templates/streamingservice/device_register.html
3:    <script src="https://cdn-zartan.s3.us-east-2.amazonaws.com/static/js/okta-auth-js.min.js" type="text/javascript"></script>

_developer/templates/developer/template.html
9:            <script src="https://cdn-zartan.s3.us-east-2.amazonaws.com/static/js/okta-auth-js.min.js" type="text/javascript"></script>

Good stuff

▶ ack https://global.oktacdn.com/okta-auth-js/5.10.0/okta-auth-js.min.js 
GlobalBehaviorandComponents/templates/components/template-singlesignon-oie.html
1:<script src="https://global.oktacdn.com/okta-auth-js/5.10.0/okta-auth-js.min.js" type="text/javascript"></script>

GlobalBehaviorandComponents/templates/components/template-singlesignon.html
1:<script src="https://global.oktacdn.com/okta-auth-js/5.10.0/okta-auth-js.min.js" type="text/javascript"></script>

To Reproduce Steps to reproduce the behavior:

  1. n/a

Expected behavior Use the CDN!!!

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information): n/a

Additional context Add any other context about the problem here.

Reference to the official okta cdn urls.

SIW

<script src="https://global.oktacdn.com/okta-signin-widget/5.16.1/js/okta-sign-in.min.js" type="text/javascript"></script>
<link href="https://global.oktacdn.com/okta-signin-widget/5.16.1/css/okta-sign-in.min.css" type="text/css" rel="stylesheet"/>

AuthJS

<script src="https://global.oktacdn.com/okta-auth-js/4.5.0/okta-auth-js.min.js" type="text/javascript"></script>

noinarisak avatar Jan 28 '22 16:01 noinarisak