John-John Tedro

Results 388 comments of John-John Tedro

Hi! If you can post a minimal isolated reproduction that would be great. If you can add [`tracing`](docs.rs/tracing) to your project, you can enable the `tracing` feature in `leaky-bucket`, it...

How are you narrowing down where the freeze is happening? How do you know it's in leaky-bucket and not in the database connection?

Assuming the timeout is on top of both layers (rate limiter + database), wouldn't the timeout trigger if the stall is in the database layer as well not allowing you...

> yes, but the timeout is only on the insert, meaning it looks something like > > ``` > fn insert_rows(rows: _) { > // first try to acquire >...

All right, so what I suggest you do is to add more instrumentation. For each step you suspect there might be a freeze, add logs like this: ```rust let id...

Some random thoughts I'm jotting down as I've been experimenting with this. Implementing `#[musli(flatten)]` has proven to be tricky, since it requires that we keep track of a ton of...

Very cool! The overall implementation looks fairly good to me. But as a starter, please remove the feature flag in favor of just checking a compile option since it can...

It would be nice if you could also break out the parsed type annotations and associated tests into a separate PR that just rejects type annotations as an error during...

So the point of integrating type checking into hir lowering is because all the work of doing type meta lookups is already done during lowering, and that it can be...

Hi! Have you reported this upstream?