John-John Tedro

Results 237 comments of John-John Tedro

Doing it in the same way as Rust sounds good to me.

I think so, all though I must admit I'm not sure what happens with the `#[path = ..]` variant 😅. I'm guessing `..` is what's being fed in? The `=`...

> As we have builtin ast which is different from rust's proc-macros, we could also have the attribute macro input be something like syn's https://docs.rs/syn/latest/syn/enum.Meta.html instead of a plain token_stream....

Derive macros should definitely declare and have their helper attributes cleaned up by the compiler. The reason there would be that other than removing those attributes the original item remains...

The error means that Rust doesn't support dynamic string interpolation. As [per the documentation](https://docs.rs/genco/latest/genco/macro.quote.html#quoted-string-interpolation), try doing this instead: `$[str](Option))]`.

I adopted test timers in #19 so that miri can be enabled in CI. Using `addr_of!` instead of pointer arithmetic is a clear improvement since MSRV has been bumped (`repr(C)`...

> At Neon, we recently had a panic triggered in tokio RawTask Waker functions, specifically about mismatched ref counts, it appeared in the callstack of leaky-bucket. We didn't find anything...

Removed and released a documentation fix. Thank you!

I'm not entirely sure how to design this either, but I'll mark it as an enhancement for now. Thanks for the input!