cdk-ec2-key-pair icon indicating copy to clipboard operation
cdk-ec2-key-pair copied to clipboard

Inconsistent names of name and keyPairName

Open ilko-rbi opened this issue 4 years ago • 2 comments

Hi,

I was confused by the fact that the constructor property for the key name is still called name, but the access property is renamed to keyPairName. Also the release notes stated that the constructor property was renamed - or have I misunderstood something? It would be nice to have a consistent names to avoid this confusion.

Thanks!

ilko-rbi avatar Aug 20 '21 14:08 ilko-rbi

ok, I've misread construct with constructor - nevertheless, the inconsistent names are still confusing IMHO...

ilko-rbi avatar Aug 20 '21 14:08 ilko-rbi

I guess you're right. To be more consistent with the core cdk modules, the name prop should be renamed keyPairName. I think that's how it's done everywhere in the core.

udondan avatar Aug 20 '21 17:08 udondan