plate icon indicating copy to clipboard operation
plate copied to clipboard

fix: subscript and superscript were mixed up

Open LeonMueller-OneAndOnly opened this issue 1 year ago • 4 comments

Dear maintainers,

I noticed following bug in the playground demo and provide a small and straight forward fix to it.

The labels were simply mixed up and the clearing behaviour could not handle changing a subscript to a supscript or vice versa.

With best regards, Leon Müller

LeonMueller-OneAndOnly avatar May 31 '24 17:05 LeonMueller-OneAndOnly

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ❌ Failed (Inspect) May 31, 2024 6:02pm

vercel[bot] avatar May 31 '24 17:05 vercel[bot]

⚠️ No Changeset found

Latest commit: 06bb33ecc63bac9ff5bd00d516c154fd49a79f02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 31 '24 17:05 changeset-bot[bot]

Thanks! Here is the error:

2024-05-31 at 20 32 56

zbeyens avatar May 31 '24 18:05 zbeyens

Weird! If have just today forked the playground demo where i use a string array (just like committed here) - in order to clear both marks for subscript and subscript when toggling one.

There typescript allowed a string array and it fixed the issue that you cant switch from subscript to supscript or vice versa.

LeonMueller-OneAndOnly avatar May 31 '24 18:05 LeonMueller-OneAndOnly