plate icon indicating copy to clipboard operation
plate copied to clipboard

Published 20 hours ago • verified publisher icon udecode

Bad ToolbarButton typing

Open Feshchenko opened this issue 1 year ago • 3 comments

Description

Hey @zbeyens thanks for you hard work.

The generated ToolbarButton has bad typing.

After toolbar generation, you will have a dustructured value in the https://github.com/udecode/plate/blob/main/templates/plate-playground-template/src/components/plate-ui/toolbar.tsx#L91 If your eslint rule no-unused-vars is set to error you will get an error. If you delete this value then you will get the type string | number | string[] here https://github.com/udecode/plate/blob/main/templates/plate-playground-template/src/components/plate-ui/toolbar.tsx#L120 But, ToolbarToggleItem expects string 🤷‍♂️

Steps to Reproduce

Environment

  • IDE
  • CI
  • terminal

Bounty

Click here to add a bounty via Algora.

Funding

  • You can sponsor this specific effort via a Polar.sh pledge below
  • We receive the pledge once the issue is completed & verified
Fund with Polar

Feshchenko avatar Oct 23 '23 09:10 Feshchenko

Thanks for the report. PR's welcome!

zbeyens avatar Oct 24 '23 15:10 zbeyens

Hello @zbeyens, I want to work on this issue please assign it to me. Thanks in advance.

lalitkumawat1m avatar Oct 24 '23 15:10 lalitkumawat1m

@lalitkumawat1m In general, you don't need to worry about getting issues assigned to you before working on them. Unless there's a bounty, the chances of multiple people working on them at the same time are quite slim.

12joan avatar Oct 24 '23 16:10 12joan