uddmorningsun

Results 15 comments of uddmorningsun

@PatrickTaibel Yes, same issue for logger. About the local `logger` variable instead of `m.logger`, you can checkout tag `v4.0.0` according to my investigation I'm confused why `v4.0.0` has fixed commit...

> I'd suggest introducing a new local variable successHandler as already done with logger and handler Good idea, I will update it

Check similar directory `/root/pixiedust/bin/` exist or not see output info? For me, `pixiedust` will download `cloudant-spark-v2.0.0-185.jar` to `/root/pixiedust/bin/cloudant-spark-v2.0.0-185.jar`, but directory `/root/pixiedust/bin/` doesn't exist. So, I create it and run again...

I found `Update branch/Update with rebase` will contains other commit to review for github (`force-pushed the master branch from 2f049e6 to 7e0e11c`), it's not my expected rebase result...😅https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-request-branch-up-to-date/ Sorry to...

It's ok for signal handler, but how to know whether there are no current users or not. So required a method to know current user number(e.g.: connection number in this...

> If no one is logged in, it could terminate GoTTY. If there are active connections, it could log how many. 👍 I have understood your meanings in preview comment...

Rebased and updated with signal handler. It's ready to review it again. @sorenisanerd

I see. Because `main.go` doesn't refer `counter`, I must add or inner `counter` attribute to `Server` struct, and then add new variable `Server` to `waitSignals()` to use `counter` field `SIGUSR1`...

Another a question, with signal handler to kill process or logging(not response JSON), it will produce extra burden for caller if running in K8S Readiness Probe or Livness Probe: *...