liquidhaskell icon indicating copy to clipboard operation
liquidhaskell copied to clipboard

Published 20 hours ago • verified publisher icon ucsd-progsys

update submodule with elimEta fix

Open yiyunliu opened this issue 5 years ago • 6 comments

I did include a negative test file which returns exit code 1 for the fixed elimEta and 2 for the buggy one. However, I need to test Wen's example before this can be safely merged.

yiyunliu avatar Feb 09 '20 19:02 yiyunliu

For some reason circleci didn't checkout the updated submodule..

yiyunliu avatar Feb 10 '20 19:02 yiyunliu

For some reason circleci didn't checkout the updated submodule..

@adinapoli didn't you fix that?

nikivazou avatar Feb 11 '20 15:02 nikivazou

@nikivazou I've stumbled into something similar (i.e. the submodule fetching weirdness representing itself) while working on the GHC 8.10 patch.

I think my original fix was incomplete, because we have to crucially install ssh and git before checking out the code. Apologies for not noticing this sooner! I was going to eventually submit a fix as part of my ghc-8.10 branch, but as this might not land for a while, I will issue the one line fix to hopefully fix this for good. Sorry again!

adinapoli avatar Feb 11 '20 15:02 adinapoli

Hopefully this PR should fix things for the better 🤞 https://github.com/ucsd-progsys/liquidhaskell/pull/1610

adinapoli avatar Feb 12 '20 07:02 adinapoli

@yiyunliu can you merge develop to this to check that it is ok?

Thanks!

nikivazou avatar Feb 12 '20 07:02 nikivazou

@nikivazou, would you like getting this PR merged, or should we close it?

facundominguez avatar Feb 06 '23 19:02 facundominguez